Top toolbar: fix half a pixel artifacting of the bottom border. #62225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +16 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
t-hamano
reviewed
Jun 3, 2024
|
Thanks for the suggestion. I tried it, and it looked as if it worked so I committed it. But on closer inspection, that causes the buttons to be offset by a little bit:
Still closer investigation surfaced that this is only an issue in distraction free mode, where the toolbar is positioned and animated using translate. This particular aspect makes it subject to subpixel rounding math, which is probably what's causing this glitch in the first place. Another option is removing the white background, what do you think? For now, I've restored the previous fix, which I don't love, but does make things still line up:
|
This approach also seems reasonable. By adding I'm sure @jeryj know a lot about toolbars, so if you have any good ideas please let me know 🙏 |
|
If |
|
That fix seems to work well!
The only question remaining, is probably one for @draganescu and related to how 3rd party plugins in some cases inject buttons there, such as custom pattern insterter tools. I vaguelly recall us adding some features to the top toolbar mode that covered those buttons unless manually collapsed. Would that regress if we remove the background color? Anyone recall a plugin that still does this, or was the behavior for how those buttons are forcefully added changed? |
t-hamano
reviewed
Jun 4, 2024
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| &.is-unstyled { | |||
| border: none; | |||
| background: transparent; | |||
There was a problem hiding this comment.
The white background doesn't originally exist in the Toolbar component itself. It exists in the BlockToolbar component, a block that extends the Toolbar component.
And I think the white background only needs to be overridden when this block toolbar is rendered in the header, so I think adding it in the place suggested in this comment might be a good idea.
There was a problem hiding this comment.
Thank you for your patience. Moved it there, and it still seems to work for me.
jasmussen
force-pushed
the
fix/dfm-artifact
branch
from
c4441e8
to
e5885cd
Compare
jasmussen
force-pushed
the
fix/dfm-artifact
branch
from
e5885cd
to
fb1e226
Compare
|
Flaky tests detected in fb1e226. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9366246617
|
t-hamano
approved these changes
Jun 4, 2024
draganescu
approved these changes
Jun 4, 2024
The original implementation of the top toolbar was a |
westonruter
added a commit
that referenced
this pull request
Jun 4, 2024
…dd/on-async-directives * 'trunk' of https://github.com/WordPress/gutenberg: (72 commits) Top toolbar: fix half a pixel artifacting of the bottom border. (#62225) Fix UI order for theme.json spacing sizes (#62199) Chore: Simplify a padding style on global styles. (#62291) Editor: Avoid remounts of `DocumentBar` (#62214) Add `default-spacing-sizes` and `default-font-sizes` options for classic themes (#62252) Editor: Cleanup styles and classnames (#62237) Scripts: Pin the @wordpress/scripts version to a version supported by WP 6.5 (#62234) Documentation: Better changelogs for the JSX transform upgrade (#62265) Chore: Simplify a padding style on dataviews. (#62276) MediaUpload: Remove dialog markup on close (#62168) Tabs: Prevent accidental overflow in indicator (#61979) Make edit site pagination buttons accessibly disabled. (#62267) Fix: Remove unused code from dataviews styles. (#62275) Re-enable React StrictMode (#61943) Inserter: Return the same items when the state and parameters don't change (#62263) Update instances of text-wrap: pretty to fall back to balance (#62233) Update: Slotfill documentation samples (links, code, and rephrase). (#62271) Try: Fix mover positioning. (#62226) [Mobile] - Image corrector - Check the path extension is a valid one (#62190) Update: Block styles documentation. ...
|
Thanks for the merge and input + reviews. |
ellatrix
added
the
Backport to WP 6.6 Beta/RC
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Top toolbar: fix half a pixel artifacting of the bottom border. * Address feedback. * Restore previous fix after all. * Use transparent background color. * Update changelog. * Move the rule to the right place. * Remove entry from changelog. Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Top toolbar: fix half a pixel artifacting of the bottom border. * Address feedback. * Restore previous fix after all. * Use transparent background color. * Update changelog. * Move the rule to the right place. * Remove entry from changelog. Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…Press#62225) * Top toolbar: fix half a pixel artifacting of the bottom border. * Address feedback. * Restore previous fix after all. * Use transparent background color. * Update changelog. * Move the rule to the right place. * Remove entry from changelog. Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.6 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In distraction free mode, or with the top toolbar enabled, there's a half pixel white artifact below the toolbar which causes the bottom border to not be coherent:
This PR fixes that by applying a max height, with no discernible side effects: