-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update URL to uppercase. #62231
Update URL to uppercase. #62231
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Good one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me, and from a quick look at the wordpress-develop core code, it's consistent in the upper case.
Size Change: -1 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Thank you for the reviews. I'll let this one sit for a little bit and let others chime in, it's been like this for a while. |
@jasmussen This is my friendly reminder to follow this #62231 (comment) |
My gosh. I've occasionally seen those automatically included, so the fact that they weren't here was my mistake. Apologies, I will do better, and thank you for the reminder. |
This was cherry-picked to the wp/6.6 branch. |
What?
Noticed that we are using URL in lowercase in this placeholder:
Shouldn't that be uppercase, since it's an acronym? This PR makes it so:
Testing Instructions
Insert a link, notice the placeholder text having uppercase URL.