fix move CONTENT_ONLY_BLOCKS into component body to ensure the editor.postContentBlockTypes filter gets called whenever the values are used
#62292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor.postContentBlockTypes` filter gets called whenever the values are used
fabiankaegy
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
noisysocks
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Makes sense. Thanks.
A bit nitpicky but can we keep the unfiltered CONTENT_ONLY_BLOCKS constant at the top level and then do this in the component?
const contentOnlyBlocks = applyFilters( 'editor.postContentBlockTypes', CONTENT_ONLY_BLOCKS );That way the capitalisation is properly indicating that the value never changes.
|
@noisysocks thanks for the review :) I updated the PR as you suggested 👍 |
…ody-to-ensure-the-filter-applies
…ody-to-ensure-the-filter-applies
fabiankaegy
deleted the
fix/move-filtered-constant-into-component-body-to-ensure-the-filter-applies
branch
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…tor.postContentBlockTypes` filter gets called whenever the values are used (#62292) Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
…tor.postContentBlockTypes` filter gets called whenever the values are used (#62292) Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
…tor.postContentBlockTypes` filter gets called whenever the values are used (WordPress#62292) Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.6 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves the
applyFilters( 'editor.postContentBlockTypes' )call into the function body of the React component where it is used.Why?
Without this change the filter only gets run once at the time the
wp-editorJS loads in the browser. This makes it almost impossible to call hook into this filter because most scripts that work with blocks havewp-editoras a dependency.How?
Moving the constant with the
applyFilterscall into the function body of the component.Testing Instructions