Editor: Make revisions more prominent #62323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ppolo99, @smithjw1. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +102 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Jay is out on a break, but we can ask @richtabor for a quick take too. I'm wondering, could it just be the "Last edited 6 days ago" that shows the revisions? Alternately, I'd lean this way:
I.e. another row. |
|
Flaky tests detected in 6f4a512. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9381447424
|
ellatrix
added
the
Backport to WP 6.6 Beta/RC
|
Agreed on showing it as an additional row. That feels like the proper weighting and like a better design choice. |
ntsekouras
force-pushed
the
add/revisions-link-in-post-summary
branch
from
6f4a512
to
c03bfc3
Compare
|
I like @jasmussen's design a lot more than my quick idea (not surprising to me). I did some quick testing in the playground using chrome and this is looking good. I see that the revisions update upon a save and that they appear after there is a second revision. Clicking them takes them to the revisions screen. I think that overall this reduces the prominence of revisions vs wp6.5 but not at the expense of making them hard to find or making the number of revisions only available on the revisions screen. Thank you! |
ntsekouras
force-pushed
the
add/revisions-link-in-post-summary
branch
from
c03bfc3
to
97d22df
Compare
I've a same question. |
Personally I think it's fine to have it in both places, but that's something designers could know better. From the technical aspect, this action is also used in Data Views, so we would need to check the APIs for something like context, we've been discussing. |
Mamaduka
approved these changes
Jun 7, 2024
| * | ||
| * @return {Component} The component to be rendered. | ||
| */ | ||
| function PostLastRevision() { |
There was a problem hiding this comment.
I'm looking at some other panel refactorings; they didn't keep the original versions. Example: #61357.
Should we do the same here?
There was a problem hiding this comment.
I don't think it's the same case because here we're not changing the entire panel (PostLastRevisionPanel) that is exported. So consumers of the above panel, should have the 'old' PostLastRevision component.
There was a problem hiding this comment.
If the policy is to keep the old components intact, then we might need to revisit some of the refactoring, like #61357. Because PostDiscussionPanel has a new structure.
There was a problem hiding this comment.
I don't think there is a clear policy about that, but I think the changes should not be disruptive in the sense that they would make sense in other designs too. An example would be if we change a control and the exporting component is just that. In this case IMO it's fine to not keep the old version. In this PR for me it made more sense to keep the old one as it matches better when used inside PostLastRevisionPanel with the panel body and we actually don't use PostLastRevisionPanel anymore in our codebase.
Can you share the components you're concerned with the discussions panel? Also cc @jorgefilipecosta for visibility.
There was a problem hiding this comment.
My concern is that the discussion panel consumers expect it to render PanelBody > PanelRow. Now, they'll get a different design.
I personally don't mind either path for changes as long as they're consistent.
There was a problem hiding this comment.
I know they get a different design and might be a bit different, but in my mind they still get the whole functionality (the whole panel). If I had to update the panel here for revisions personally I'd follow the same approach with the discussions panel. This is subjective though..
|
I'd remove the link from the menu. |
|
This is much better, cheers for actioning. |
|
Let's land this and explore how to remove the action in the editor context separately in actions API. |
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Unlinked contributors: ppolo99, smithjw1. Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: creativecoder <grantmkin@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: hrkhal <hrkhal@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
Unlinked contributors: ppolo99, smithjw1. Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: creativecoder <grantmkin@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: hrkhal <hrkhal@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Unlinked contributors: ppolo99, smithjw1. Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: creativecoder <grantmkin@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: aaronjorbin <jorbin@git.wordpress.org> Co-authored-by: hrkhal <hrkhal@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.6 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #62041
There is some feedback in the issue that the revisions link and revisions number should be a bit more prominent, besides the post action in the ellipsis menu. This PR adds this info in post summary like suggested in the below comment.
Testing Instructions
Screenshots or screencast