Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API template create block: Removed warning for generated README from template #62324

Conversation

juanmaguitar
Copy link
Contributor

What?

Removes the following Warning from the generated README when using create-block-interactive-template template for create-block tool

This block requires Gutenberg 16.2 or superior to work. The Interactivity API is, at the moment, not part of WordPress Core as it is still very experimental, and very likely to change.

Why?

Because the API has evolved since that message was set and that warning is not needed anymore

Copy link

github-actions bot commented Jun 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanmaguitar <juanmaguitar@git.wordpress.org>
Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbravobernal cbravobernal added [Packages] Interactivity /packages/interactivity [Type] Developer Documentation Documentation for developers labels Jun 5, 2024
@juanmaguitar juanmaguitar enabled auto-merge (squash) June 5, 2024 10:09
@juanmaguitar juanmaguitar merged commit 06470bb into trunk Jun 5, 2024
67 of 68 checks passed
@juanmaguitar juanmaguitar deleted the docs/interactivity-api-template-create-block-remove-warning branch June 5, 2024 11:58
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 5, 2024
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Packages] Interactivity /packages/interactivity [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants