FlatTermSelector: Update the term suggestion limit #62359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: +1 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @fcenteno, @keenode. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@fcenteno, I also tried to adjust ordering here, but the current options seem to be the most optimal. My tests were based on your example where multiple tags contain the word "music". The full word match (Music) was always first in my results. Testing data
|
t-hamano
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
LGTM!
I tested the steps described in this comment. As you said, it seems that exact matches are given priority.
|
Thank you, @t-hamano! |
Mamaduka
force-pushed
the
update/flat-term-suggestion-limit
branch
from
705fe10
to
18de8fc
Compare
|
Flaky tests detected in 18de8fc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9402785596
|
@Mamaduka Here is my example: The tag "Managua" exists, but it is impossible to select it because the word Managua does not appear first, but instead shows tags with more than 1 word in alphabetical order: In the case of having more than 100 tags in the list, and if there are more than 100 cases where that word is part of a tag with more than 1 word, I will never be able to add it, because when pressing enter we get a 400 error. I really appreciate your help finding a solution. |
|
Thanks for another example, @fcenteno! It's odd that I'm getting a different result. Maybe it's related to locale (language) because in my tests, the whole match (Music) always comes, and then I get partial matches (A Music). The PR description has details on why we're limited to 100 results for the moment. I want to highlight this again: The 400 error is okay; the editor knows how to handle this specific error and correctly assign a term to a post. |
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Unlinked contributors: fcenteno, keenode. Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #60791.
PR updates the number of suggestions rendered for the
FlatTermSelectorcomponent when searching terms.Why?
How the max suggestions limit was chosen:
per_pagerange set by the REST API.FormTokenFieldneeds a fixed limit for display.FormTokenField.Testing Instructions
wp term generate post_tag --count=1000Testing Instructions for Keyboard
Same.