Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Update button on mobile #6353

Merged
merged 1 commit into from Apr 24, 2018
Merged

Show Update button on mobile #6353

merged 1 commit into from Apr 24, 2018

Conversation

jasmussen
Copy link
Contributor

This fixes a regression where the Update button was invisible for already published posts on mobile.

screen shot 2018-04-23 at 12 56 43

This fixes a regression where the Update button was invisible for already published posts on mobile.
@jasmussen jasmussen added the Mobile Web Viewport sizes for mobile and tablet devices label Apr 23, 2018
@jasmussen jasmussen self-assigned this Apr 23, 2018
@jasmussen jasmussen requested a review from a team April 23, 2018 10:58
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Confirmed that this squashes the bug!

@jasmussen
Copy link
Contributor Author

Yaas. It's a merging spree!

@jasmussen jasmussen merged commit 0f904e1 into master Apr 24, 2018
@jasmussen jasmussen deleted the fix/mobile-update-button branch April 24, 2018 07:01
@@ -27,8 +27,7 @@
top: $admin-bar-height;
}

.editor-post-switch-to-draft + .editor-post-preview,
.editor-post-switch-to-draft + .editor-post-preview + .editor-post-publish-button {
.editor-post-switch-to-draft + .editor-post-preview {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab before the { should be space 😄

jasmussen added a commit that referenced this pull request Apr 25, 2018
Caught by @aduth in #6353 (review) — my typo. This PR fixes it. I'll be sure to fix my linter.
nuzzio pushed a commit to nuzzio/gutenberg that referenced this pull request Apr 25, 2018
This fixes a regression where the Update button was invisible for already published posts on mobile.
jasmussen added a commit that referenced this pull request Apr 25, 2018
Caught by @aduth in #6353 (review) — my typo. This PR fixes it. I'll be sure to fix my linter.
@mtias mtias added this to the 2.8 milestone May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile Web Viewport sizes for mobile and tablet devices
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants