Update: Move the density picker to the view options menu. #63852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +266 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
It works, but I don't think this is ideal from an a11y perspective, for the reasons Marco stated here: #63367 (comment). If we commit to this direction we should probably revisit the design for the view options menu altogether, transitioning from a |
|
If we move from a dropdown to a popover I guess this design could work and be accessible right? Another option can a dropdown menu item open a popover with a custom UI? cc: @ciampo Pressing to change the item size would then open a popover with the slider to change the item size. Or it would replace the dropdown contents with a slider to change the item size, and a back button to go back to the main dropdown. Which option should we explore first? I'm also open to trying other options. cc: @jameskoster |
|
My understanding is that to satisfy a11y requirements we cannot mix the range control into the menu. So the options appear to be:
The first option seems better to me as it will allow for more design expression. It needs exploration though. I'll make a new issue :) |
Maybe something like could work?
|
|
That's what I tried to describe as option number 2. It meets the a11y requirement but is much less ergonomic to use compared with the range slider. In the short term I don't mind leaving the range slider as it is, while we figure out how to incorporate it into the view options (#63872). However, I also wouldn't object to implementing 'option 2' in the short-term if there's a strong desire to do so. |
|
Closing in favor of #64175. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results from the conversations on #63367 with @youknowriad and @jameskoster.
It moves the density picker to be under the view config menu, decreasing the number of visible buttons at the top.
Screenshots
Testing Instructions
I verified the density picker is available on the view config menu and still works as expected.