RTL: Fix showing/hiding the right block side UI on RTL languages #6400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
gziolo
reviewed
Apr 25, 2018
| const { width, left, right } = this.container.getBoundingClientRect(); | ||
|
|
||
| let hoverArea = null; | ||
| if ( ( event.clientX - left ) < width / 3 ) { | ||
| hoverArea = 'left'; | ||
| hoverArea = isRtl ? 'right' : 'left'; |
There was a problem hiding this comment.
I think it should be called isRTL, similar to findDOMNode.
Would it make sense to introduce a helper like:
const direction = ( value) => {
if ( ! isRTL) {
return value;
}
return value === ‚right’ ? ‚left’ : ‚right’;
};
My mobile keyboard is a bit limited 😭
There was a problem hiding this comment.
I personally don't think adding this helper will help. I like dumb code :)
I'll update to isRTL
youknowriad
force-pushed
the
fix/rtl-block-side-ui
branch
from
a5b2772
to
5c8dc8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6366
In RTL languages, if we hover the right area, the left side UI was shown and vice verca. This PR fixes it.
Testing instructions
(Do the same on LTR languages as well)