Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add npm update to build script #6656

Merged
merged 1 commit into from
May 9, 2018
Merged

Conversation

tofumatt
Copy link
Member

@tofumatt tofumatt commented May 9, 2018

Since #6629, npm 6 in the minimum version, so install it at setup time. Really this installs the latest version because I didn't want to deal with adding yet another 6 somewhere. If that's too dangerous we can change this to be explicitly 6–let me know.

This threw me because I created a PR and ran the app with npm 5 and received no error messages. It wasn't until my noisy PR came in that @gziolo pointed out I was running an out-of-date npm.

Description

Globally install npm during set up.

How has this been tested?

Ran the script on a new machine; it worked.

Types of changes

Add npm install npm -g to start up.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

Since #6629, npm 6 in the minimum version, so install it at setup time.
@tofumatt tofumatt requested review from pento and gziolo May 9, 2018 12:27
@gziolo gziolo added the [Type] Build Tooling Issues or PRs related to build tooling label May 9, 2018
@gziolo gziolo added this to the 2.9 milestone May 9, 2018
@gziolo
Copy link
Member

gziolo commented May 9, 2018

Good idea 👍

@tofumatt tofumatt merged commit 7bb1934 into master May 9, 2018
@tofumatt tofumatt deleted the update/npm-up-to-date branch May 9, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants