Data Module: Move the data reference to the root level #7627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Developer Documentation
youknowriad
commented
Jun 29, 2018
| - [**core/edit-post**: The Editor's UI Data](../../docs/data/core-edit-post.md) | ||
| - [**core/viewport**: The viewport module Data](../../docs/data/core-viewport.md) | ||
| - [**core/nux**: The NUX (New User Experience) module Data](../../docs/data/core-nux.md) |
There was a problem hiding this comment.
This is the trick, I saw it used elsewhere, not certain how it works though.
tofumatt
approved these changes
Jun 29, 2018
| @@ -154,6 +167,20 @@ saved state of the post. | |||
|
|
|||
| Post attribute value. | |||
|
|
|||
| ### getAutosaveAttribute | |||
|
|
|||
| Returns an attribute value of the current autosave revision for a post, or | |||
There was a problem hiding this comment.
As mentioned to @aduth, I think it's better if we don't put newlines in our prose for markdown. It makes it harder to refactor/type/diff, and I don't really think it improves readability (people reading in 80-character windows will/should have wrapping on 🤷♂️).
youknowriad
force-pushed
the
fix/data-module-docs
branch
from
fa1b86a
to
0ef44f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the data module docs by moving them to the root level of the handbook. Even if the handbook supports nested levels, it doesn't look good.
Also tries to fix the links in the table of contents and use a "trick" to make them work in both github and the handbook.