Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview: Open preview to previewLink if not autosaveable #7703

Merged
merged 4 commits into from
Jul 6, 2018

Commits on Jul 5, 2018

  1. Configuration menu
    Copy the full SHA
    f757da6 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2018

  1. Saving: Update preview button test for interstitial with preview link

    Previously we would allow the previous link to be reused; now we force to about:blank to write the empty interstitial message
    aduth committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    103f37b View commit details
    Browse the repository at this point in the history
  2. Saving: Avoid unsetting previewWindow on unload event

    Unload can be triggered in Firefox merely by the writing to the interstitial window. Only delete once a redirect has been evaluated (and not closed).
    aduth committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    ccd822a View commit details
    Browse the repository at this point in the history
  3. Saving: Compare preview location on reference window object

    previewWindow is deleted from the instance once props are set, but reference object location is mutated directly
    aduth committed Jul 6, 2018
    Configuration menu
    Copy the full SHA
    6207411 View commit details
    Browse the repository at this point in the history