Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packages: Move packages repository into Gutenberg (2nd try) #7805

Merged
merged 458 commits into from
Jul 9, 2018
Merged

Packages: Move packages repository into Gutenberg (2nd try) #7805

merged 458 commits into from
Jul 9, 2018
+8,550 −856

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Jul 9, 2018

Description

2nd try to merge https://github.com/WordPress/packages into Gutenberg. This time hopefully with history preserved, in contrast to #7556 :)

Adam Silverstein and others added 30 commits September 12, 2017 08:42
update hook and vendor/plugin/function wording, removing Name
73744fa
complte namespace shortening to vendor/plugin/function
7465667
Merge pull request #13 from adamsilverstein/add-wp-hooks
18fed13 
Add the WordPress hook library from 21170-core in preparation for beta npm release
Merge branch 'master' of github.com:WordPress/packages
48e6cda
Publish
5b19507 
 - @wordpress/a11y@0.1.0-beta.2
 - @wordpress/dom-ready@0.1.0-beta.2
 - @wordpress/hooks@0.1.0-beta.0
 - @wordpress/url@0.1.0-beta.2
add publishConfig->access:public for hooks
01902b3
Merge branch 'make-hooks-public'
c45acef
Publish
cc83cde 
 - @wordpress/hooks@0.1.0-beta.1
correctly enable dashes in regexes in validateNamespace
5ae0096
Export a hooks function enabling adding hooks via composition
5329048
test hooks can be instantiated
7dc5198
Run test on objects instead of globally
8931715
correct data return for Hooks
44c0c6f
Rework the Hooks object, use a local HOOKS instead of global
e9c7002
use object based hooks throughout testing
7c69c03
remove unused global HOOKS
3863e35
remove some logging
3ccbc36
remove extra parts from namespace in tests
76f706a
remov vendor/plugin prefix requirement for namespaces
f552dae
update docs
a71e346
Add a test for “Can add filters with dashes in namespaces”
3b19868
Merge pull request #39 from WordPress/fix/correct-namespace-check-for…
74212b9 
…-hooks

Correctly enable dashes in regexes in validateNamespace
@aduth
a11y: Apply .screen-reader-text styles to container
8fffdc8
@aduth
a11y: Update tests per updated style
49e57d9 
Questionable value of the test assertions, which are specific to the implementation and not the expected intent of the test case
update readme, add some tests
adf8b18
Merge branch 'master' of github.com:WordPress/packages
5aa44bd
Merge branch 'master' into add-hooks-via-composition
4f07420 
# Conflicts:
#	packages/hooks/src/test/index.test.js
#	packages/hooks/src/validateNamespace.js
switch naming to createHooks and correct tests
b8d5f28
remove extraneous single quotes
031fdfd
remove the HOOKS global abstraction
4cf3749
ntwb and others added 17 commits June 27, 2018 16:27
@ntwb
Add is-shallow-equal/benchmark to codecov ignore
9c2d450
@ntwb
Remove npm-run-all
a268477
@gziolo
Packages: Synchronize dependencie to avoid having copies of the same …
92d6981 
…libraries
@gziolo
Tests: Update test config to work with local packages
b55e242
@ntwb
ESLint initial fixes via --fix
192b4df
@gziolo
Build: Make Webpack build work again :)
bdad685
@gziolo
Build: Fix the issue with babel makepot plugin
e1a4281
@gziolo
Packages: Fix all linter errors
d1b00d5
@gziolo
Build: Use Lerna 3 for managing packages
bc6aff3 
It folows the setup of Lerna itself which demonstrates "the golden path of local file: specifiers at scale".
See: lerna/lerna#1307.
@gziolo
Merge remote-tracking branch 'origin/master' into add-packages
56f9852
@gziolo
Packages: Fix configuration with newly introduced packages
cf5acdc
@gziolo
Testing: Try to fix jest-console tests
713980a
@gziolo
Testing: Try to fix jest-console tests
7ec4171
@ntwb
Merge branch 'add-packages' of github.com:WordPress/gutenberg into ad…
aa17df7 
…d-packages
@ntwb
jest-preset-default: Alphabetize dependencies
1bc5ff6
@gziolo
Testing: Use toThrowError matcher for jest-console
af26e94
@gziolo
Merge remote-tracking branch 'origin/master' into add-packages
00b3825
@gziolo gziolo added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Build Tooling Issues or PRs related to build tooling npm Packages Related to npm packages labels Jul 9, 2018
@gziolo gziolo added this to the 3.3 milestone Jul 9, 2018
@gziolo gziolo self-assigned this Jul 9, 2018
@gziolo gziolo requested review from ntwb and omarreiss July 9, 2018 08:21
ntwb
ntwb approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit:

@gziolo gziolo merged commit 921e9d8 into master Jul 9, 2018
@gziolo gziolo deleted the add-packages branch July 9, 2018 08:52
@aduth aduth mentioned this pull request Jul 10, 2018
Merged
ntwb pushed a commit that referenced this pull request Jul 10, 2018
@aduth @ntwb
Framework: Reorder package.json devDependencies alphabetically (#7867)
18b7f36 
This pull request seeks to update `package.json` to apply correct alphabetical ordering to `devDependencies`. This change was observed with a simple `npm install`, likely related to the merge of packages in #7805.

**Testing instructions:**

Ensure npm installs without issue:

```
npm install
```

Should be no impact on the application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntwb ntwb ntwb approved these changes

@omarreiss omarreiss Awaiting requested review from omarreiss

Assignees

@gziolo gziolo

Labels
Framework Issues related to broader framework topics, especially as it relates to javascript npm Packages Related to npm packages [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@gziolo @ntwb @aduth @omarreiss @afercia @youknowriad @nerrad @ryanwelcher @pento @aaronjorbin