Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: add suggestedPostFormat selector. #864

Merged
merged 2 commits into from
May 22, 2017
Merged

Conversation

mtias
Copy link
Member

@mtias mtias commented May 22, 2017

Returns a suggested post format based on what blocks exist in the post. This is an initial approximation to a flow that is able to set post format for the user based on the kind of content they have added.

image

Returns a suggested post format based on what blocks exist in the post.
@mtias mtias added General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Document Settings Document settings experience labels May 22, 2017
@jasmussen
Copy link
Contributor

I dig this!

If we can make what currently says "Image" in the screenshot into a selectable dropdown, then in my book that closes #857.

@mtias
Copy link
Member Author

mtias commented May 22, 2017

Yes, initial goal is read only. Then we can figure out how the interaction works—if you set it manually we should not overwrite your decision, etc.

@ellatrix
Copy link
Member

Nice! Maybe it could be a bit less strict? What about we look at the first object, and if there's no other objects in the post, suggest that object. E.g. If the first block is an image, but the rest text, it would still suggest "Image". As soon as you add a video/quote/table etc. though, it would revert to post. That way you can write something longer about the image.

@ellatrix
Copy link
Member

Anyway, just a suggestion. :) We can iterate of course.

@mtias
Copy link
Member Author

mtias commented May 22, 2017

Absolutely, we can adjust the heuristics as we go. :)

The only concern would be to be too eager in recognizing a pattern to the point it becomes an annoyance to people. Given we have limited awareness of what themes may be doing with these (adding all image format posts into a slideshow on the homepage, for instance) I think being more cautious could prove to be good, but we need to try.

@mtias mtias merged commit 258e44a into master May 22, 2017
@mtias mtias deleted the add/suggested-format branch May 22, 2017 17:45
@jasmussen
Copy link
Contributor

Worth also looking at what the mobile team has been doing here. I believe there's some inferrence going on in the native app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Document Settings Document settings experience General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants