New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Bump npm-package-json-lint lock to 3.3.1 #9321

Merged
merged 2 commits into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented Aug 24, 2018

Related: tclindner/npm-package-json-lint#91

This pull request seeks to resolve an issue where npm package lint script does not work in Windows environments.

Testing instructions:

Install updated dependencies:

npm install

In Windows and your preferred operating system, ensure that you can run npm run lint.

@aduth aduth added the Framework label Aug 24, 2018

@aduth aduth requested review from azaozz and ntwb Aug 24, 2018

- Resolves an issue where npm package lint script did not work in Windows environments ([#9321](https://github.com/WordPress/gutenberg/pull/9321)
### Updated Dependencies
- Updated dependencies: `jest`, `npm-package-json-lint` and `read-pkg-up`

This comment has been minimized.

@ntwb

ntwb Aug 25, 2018

Member

The above ### Updated Dependencies section isn't (currently) documented in the recent maintaining-changelogs docs updates, I added it as the existing line looked out of place per the ### Bug Fix heading above which of course the deps updates are not bug fixes.

@ntwb

ntwb Aug 25, 2018

Member

The above ### Updated Dependencies section isn't (currently) documented in the recent maintaining-changelogs docs updates, I added it as the existing line looked out of place per the ### Bug Fix heading above which of course the deps updates are not bug fixes.

@ntwb

This comment has been minimized.

Show comment
Hide comment
@ntwb

ntwb Aug 25, 2018

Member

The extra dependency bumps I made in 1de36d8 were the only way to get Travis CI jobs o pass...

Member

ntwb commented Aug 25, 2018

The extra dependency bumps I made in 1de36d8 were the only way to get Travis CI jobs o pass...

@ntwb

ntwb approved these changes Aug 25, 2018

@ntwb

This comment has been minimized.

Show comment
Hide comment
@ntwb

ntwb Aug 28, 2018

Member

No issues testing this on my Windows PC

λ» npm run lint

> gutenberg@3.6.2 lint C:\Users\Stephen\dev\gutenberg
> concurrently "npm run lint-js" "npm run lint-pkg-json" "npm run lint-css"

[0]
[0] > gutenberg@3.6.2 lint-js C:\Users\Stephen\dev\gutenberg
[0] > eslint .
[0]
[1]
[1] > gutenberg@3.6.2 lint-pkg-json C:\Users\Stephen\dev\gutenberg
[1] > wp-scripts lint-pkg-json ./packages
[1]
[2]
[2] > gutenberg@3.6.2 lint-css C:\Users\Stephen\dev\gutenberg
[2] > stylelint '**/*.scss'
[2]
[2] npm run lint-css exited with code 0
[1] npm run lint-pkg-json exited with code 0
Terminate batch job (Y/N)? [0] Terminate batch job (Y/N)?
[0] npm run lint-js exited with code 1

When forcing a lint error also works as expected:

Altering a packages license field in its `package.json` to force an error results in:
```./packages\a11y\package.json
× valid-values-license - node: license - Invalid value for license
1 error
0 warnings

Totals
1 error
0 warnings```
Member

ntwb commented Aug 28, 2018

No issues testing this on my Windows PC

λ» npm run lint

> gutenberg@3.6.2 lint C:\Users\Stephen\dev\gutenberg
> concurrently "npm run lint-js" "npm run lint-pkg-json" "npm run lint-css"

[0]
[0] > gutenberg@3.6.2 lint-js C:\Users\Stephen\dev\gutenberg
[0] > eslint .
[0]
[1]
[1] > gutenberg@3.6.2 lint-pkg-json C:\Users\Stephen\dev\gutenberg
[1] > wp-scripts lint-pkg-json ./packages
[1]
[2]
[2] > gutenberg@3.6.2 lint-css C:\Users\Stephen\dev\gutenberg
[2] > stylelint '**/*.scss'
[2]
[2] npm run lint-css exited with code 0
[1] npm run lint-pkg-json exited with code 0
Terminate batch job (Y/N)? [0] Terminate batch job (Y/N)?
[0] npm run lint-js exited with code 1

When forcing a lint error also works as expected:

Altering a packages license field in its `package.json` to force an error results in:
```./packages\a11y\package.json
× valid-values-license - node: license - Invalid value for license
1 error
0 warnings

Totals
1 error
0 warnings```

@ntwb ntwb added this to the 3.7 milestone Aug 28, 2018

@ntwb ntwb merged commit f688989 into master Aug 28, 2018

2 checks passed

codecov/project 50.59% (-0.01%) compared to c28bc57
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ntwb ntwb deleted the update/npm-package-json-lint branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment