Framework: Bump npm-package-json-lint lock to 3.3.1 #9321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
ntwb
reviewed
Aug 25, 2018
| - Resolves an issue where npm package lint script did not work in Windows environments ([#9321](https://github.com/WordPress/gutenberg/pull/9321) | ||
|
|
||
| ### Updated Dependencies | ||
|
|
||
| - Updated dependencies: `jest`, `npm-package-json-lint` and `read-pkg-up` |
There was a problem hiding this comment.
The above ### Updated Dependencies section isn't (currently) documented in the recent maintaining-changelogs docs updates, I added it as the existing line looked out of place per the ### Bug Fix heading above which of course the deps updates are not bug fixes.
|
The extra dependency bumps I made in 1de36d8 were the only way to get Travis CI jobs o pass... |
ntwb
approved these changes
Aug 25, 2018
|
No issues testing this on my Windows PC λ» npm run lint
> gutenberg@3.6.2 lint C:\Users\Stephen\dev\gutenberg
> concurrently "npm run lint-js" "npm run lint-pkg-json" "npm run lint-css"
[0]
[0] > gutenberg@3.6.2 lint-js C:\Users\Stephen\dev\gutenberg
[0] > eslint .
[0]
[1]
[1] > gutenberg@3.6.2 lint-pkg-json C:\Users\Stephen\dev\gutenberg
[1] > wp-scripts lint-pkg-json ./packages
[1]
[2]
[2] > gutenberg@3.6.2 lint-css C:\Users\Stephen\dev\gutenberg
[2] > stylelint '**/*.scss'
[2]
[2] npm run lint-css exited with code 0
[1] npm run lint-pkg-json exited with code 0
Terminate batch job (Y/N)? [0] Terminate batch job (Y/N)?
[0] npm run lint-js exited with code 1When forcing a lint error also works as expected: Altering a packages license field in its `package.json` to force an error results in:
```./packages\a11y\package.json
× valid-values-license - node: license - Invalid value for license
1 error
0 warnings
Totals
1 error
0 warnings``` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: tclindner/npm-package-json-lint#91
This pull request seeks to resolve an issue where npm package lint script does not work in Windows environments.
Testing instructions:
Install updated dependencies:
In Windows and your preferred operating system, ensure that you can run
npm run lint.