Add end 2 end test to font size to font choosing mechanism. #9380
Conversation
| await clickBlockAppender(); | ||
| await page.keyboard.type( 'Paragraph to be made "small"' ); | ||
|
|
||
| await page.click( '.blocks-font-size .components-range-control__number' ); |
There was a problem hiding this comment.
if the logic between lines 92 and 100 won't work, this test will still pass. The same applies to other tests which reset the font size. Do you have an idea how to mitigate it?
There was a problem hiding this comment.
Hi @gziolo to mitigate this problem, we have very similar tests containing the part where we set the font size. So if lines 92-100 don't work this test will pass but the tests where we set the font size are going to fail because the logic is the same. In summary, if lines 92-100 don't work it means the setting of the font size is not working, and we are testing that.
Another approach would be to use the data-layer functions to insert the block with the font size already set. But even this approach is not perfect if the block was not created correctly, the test may still pass wrongly.
There was a problem hiding this comment.
Sounds reasonable 👍 I wasn’t aware that it is tested in other place
Description
Until now, we had no end 2 end test testing the font size choosing logic and we were unable to catch some problems as #9191.
This PR adds a set of the end 2 end tests that test if the font size choosing mechanism is working correctly.
How has this been tested?
I checked that the new end 2 end tests pass and I introduced some bugs on purpose ( eg.: the revert of https://github.com/WordPress/gutenberg/pull/9253/files) and verified they fail.