Fix no-preview placeholder BlockIcon usage #9466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves: #9444 |
jorgefilipecosta
approved these changes
Aug 31, 2018
| @@ -188,10 +188,10 @@ export function getEmbedEdit( title, icon ) { | |||
| ); | |||
| } | |||
|
|
|||
| const label = sprintf( __( '%s URL' ), title ); | |||
|
|
|||
| if ( ! preview || previewIsFallback || editingURL ) { | |||
| // translators: %s: type of embed e.g: "YouTube", "Twitter", etc. "Embed" is used when no specific type exists | |||
There was a problem hiding this comment.
I think the translator comment also needs to be moved to be in the line before the label.
There was a problem hiding this comment.
Gah, I missed that one! Thanks :)
notnownikki
deleted the
fix/embed-block-update-for-blockicon-in-no-preview-placeholder
branch
mtias
reviewed
Sep 6, 2018
| @@ -237,7 +237,7 @@ export function getEmbedEdit( title, icon ) { | |||
| <figure className={ classnames( className, 'wp-block-embed', { 'is-video': 'video' === type } ) }> | |||
| { controls } | |||
| { ( cannotPreview ) ? ( | |||
| <Placeholder icon={ icon } label={ __( 'Embed URL' ) }> | |||
| <Placeholder icon={ <BlockIcon icon={ icon } showColors /> } label={ label } className="wp-block-embed"> | |||
There was a problem hiding this comment.
Why are we duplicating the class attribute here (it's already on the figure above)? cc @notnownikki @jorgefilipecosta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Placeholder used to URLs that can be embedded but can't be previewed in the editor due to sandbox security settings.
How has this been tested?
Create a new post, try to embed https://www.facebook.com/buzzfeedladylike/posts/2290362924583261
Types of changes
Bug fix
Checklist: