Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line heights are incorrectly configured in Tailwind #477

Closed
dhruvkb opened this issue Dec 22, 2022 · 0 comments · Fixed by #946
Closed

Line heights are incorrectly configured in Tailwind #477

dhruvkb opened this issue Dec 22, 2022 · 0 comments · Fixed by #946
Assignees
@obulat
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🤯 ノಠ益ಠノ彡┻━┻ Aaargh! 🧱 stack: frontend Related to the Nuxt frontend

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Dec 22, 2022 •
edited
Loading

Description

The Tailwind configuration for line-heights is ignored because the key is supposed to be lineHeight (not plural). This means our custom config is ignored and the built-in line heights are used.

https://github.com/WordPress/openverse-frontend/blob/9ba8cd356689ce81e0153592b29ace57d866c236/tailwind.config.js#L170

A little bit of this fix has been started in WordPress/openverse-frontend#2060 (relevant diff and diff) where it was first spotted.

Additional context

It should be addressed separately as it will break almost every existing visual regression snapshot (hence the label).
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software 🤯 ノಠ益ಠノ彡┻━┻ Aaargh! labels Dec 22, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@obulat obulat self-assigned this Mar 28, 2023
@obulat obulat mentioned this issue Mar 28, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obulat obulat

Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🤯 ノಠ益ಠノ彡┻━┻ Aaargh! 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Tailwind line heights WordPress/openverse
2 participants
@obulat @dhruvkb