Fix Tailwind line heights #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2.46 kB (0%) Total Size: 846 kB
ℹ️ View Unchanged
|
|
Full-stack documentation: https://docs.openverse.org/_preview/946 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
added
🟨 priority: medium
obulat
force-pushed
the
fix/tw_linehights
branch
2 times, most recently
from
3e3f94d
to
53f8521
Compare
|
Yesterday I shared a concern that this PR might conflict with what we understand as a source of truth for designs, but I understood the PR scope incorrectly and now I see what you @obulat were talking about. My idea for revisiting the text styles is making consistent five heigh-line cases we currently have.
So based on the slack thread message, we are addressing this problem first, and then defining the values for the cases mentioned above. |
Yes, we will be able to fully address the cases you list after fixing the code for line heights in this PR! |
obulat
force-pushed
the
fix/tw_linehights
branch
2 times, most recently
from
1bb9a5a
to
a5708a8
Compare
obulat
added
🟧 priority: high
|
@obulat is this ready for review? |
Yes |
obulat
force-pushed
the
fix/tw_linehights
branch
from
a5708a8
to
a4a7bee
Compare
obulat
force-pushed
the
fix/tw_linehights
branch
from
ce4240d
to
e8cd82d
Compare
|
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR: @zackkrida Excluding weekend1 days, this PR was updated 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes |
obulat
force-pushed
the
fix/tw_linehights
branch
from
e8cd82d
to
62abe99
Compare
zackkrida
reviewed
Apr 3, 2023
zackkrida
approved these changes
Apr 3, 2023
Co-authored-by: Zack Krida <zackkrida@pm.me>
dhruvkb
approved these changes
Apr 5, 2023
7 tasks
dhruvkb
pushed a commit
that referenced
this pull request
Apr 14, 2023
* Adjust year ranges * Adjust initial range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #947 by @obulat
Fixes #477 by @dhruvkb
Description
This PR moves the line height settings to
extendand adjust them so that only the set values are used, and not the Tailwind default fallback. This means that a lot of snapshots need to be updated because in many places, the line height was set to 1.375 or 1.25 instead of 1.3 instead of 1.3 as in Openverse mockups.You can see the current values for named line heights in the Tailwind viewer: https://wordpress.github.io/openverse/tailwind/#Line%20Height (Compare to this PR: https://wordpress.github.io/openverse/_preview/946/tailwind/#Line%20Height)
This PR is important before the work on Core UI improvements because the line height of the buttons is also affected. We could also add this to the scope of Core UI improvements project.
Testing Instructions
Check the snapshots - they should look fairly similar, but the heights should change slightly. Everything should build fine (no errors of
classnot found for tailwind build step)Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin