Fix Storybook tests by waiting for URL instead of a port #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
🟥 priority: critical
obulat
changed the title
7 tasks
|
Size Change: -2.62 kB (0%) Total Size: 843 kB
ℹ️ View Unchanged
|
|
Full-stack documentation: https://docs.openverse.org/_preview/1137 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
dhruvkb
approved these changes
Apr 5, 2023
* Update TW line-heights * Update snapshots * Update storybook snapshots * Use the named styles * Update frontend/src/styles/tailwind.css Co-authored-by: Zack Krida <zackkrida@pm.me> * Fix storybook tests running before server is ready --------- Co-authored-by: Zack Krida <zackkrida@pm.me>
Co-authored-by: Dhruv Bhanushali <hi@dhruvkb.dev>
zackkrida
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1135 by @obulat
Description
Playwright accepts either
portorurlconfiguration for the webserver, and checks if one of them is ready before running tests. It seems that theportis "ready" before Storybook is fully built, which makes the first couple of tests fail.This PR replaces the
portwith the first test's URL to make sure that the Storybook is fully built and ready to run tests.Note: the fix has been merge as part of #946, but this PR still should be merged as it uses a better url than the one in main now.
Testing Instructions
The CI should pass. These changes were added to #1132 to make it pass the CI tests.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin