Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use add-to-project-and-label action #1138

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Apr 5, 2023

Fixes

Related to #818 by @obulat

Description

This PR adds an external TypeScript action that adds an issue to the Openverse project and sets the Project's Priority custom field value based on the issue's label. The action is based on the add-to-project action.

You can see a successful run here: https://github.com/bulatt3/mobile_test/actions/runs/4620463360 (Please ignore the more than 40 unsuccessful runs 😆 )

I think it would be best to move the action to a /WordPress/ repository, but it would be nice to test it before the move.

Testing Instructions

Merge and see

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: mgmt Related to repo management and automations labels Apr 5, 2023
@obulat obulat requested a review from a team as a code owner April 5, 2023 16:09
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to say that bulatt3/add-to-project-and-label seems to be on an unstable version, before I realised you're @bulatt3! Which led me to wonder if it's easier to build on top of #1130 and include this package inside the repo itself?

@obulat
Copy link
Contributor Author

obulat commented Apr 6, 2023

I was about to say that bulatt3/add-to-project-and-label seems to be on an unstable version, before I realised you're @bulatt3! Which led me to wonder if it's easier to build on top of #1130 and include this package inside the repo itself?

Yes, I've created that organization some time ago :)
That's a great approach, @dhruvkb, I was looking for something similar before going with what I did here.
I would love to move these changes on top of #1130. It seems that the changes there are at least a week away from being merged, and I would really love to try if this automation works before that...

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge it into the monorepo later. Let's give it a go.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it, let's give it a shot!

@obulat obulat merged commit fe76080 into main Apr 6, 2023
@obulat obulat deleted the fix/new_issue_automation branch April 6, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants