Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta-file sync workflow #1224

Merged
merged 4 commits into from Apr 16, 2023
Merged

Fix meta-file sync workflow #1224

merged 4 commits into from Apr 16, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Apr 15, 2023

Description

This PR

  • removes redundant templates and scaffolding to compile them
  • updates sync configuration
    • removing all sync jobs targeting the catalog
    • removing sync for the deleted templates
  • updates the root README.md
    • to clarify the purpose of template/
    • to remove a duplicated mention of the catalog/
  • removes redundant hooks from .pre-commit-config.yaml

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Apr 15, 2023
@dhruvkb dhruvkb requested a review from a team as a code owner April 15, 2023 01:26
@openverse-bot openverse-bot added this to Needs review in Openverse PRs Apr 15, 2023
@dhruvkb dhruvkb added this to the Monorepo milestone Apr 15, 2023
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Openverse PRs automation moved this from Needs review to Reviewer approved Apr 16, 2023
@dhruvkb dhruvkb merged commit 4be0de6 into main Apr 16, 2023
35 checks passed
Openverse PRs automation moved this from Reviewer approved to Merged! Apr 16, 2023
@dhruvkb dhruvkb deleted the fix_sync branch April 16, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: mgmt Related to repo management and automations
Projects
No open projects
Openverse PRs
  
Merged!
Development

Successfully merging this pull request may close these issues.

None yet

3 participants