Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing argument in Pool.create_or_update_pool #2876

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Aug 23, 2023

Fixes

Fixes CI failure on Dependabot PR #2869

Description

This is a separate PR and not committed directly to the Dependabot PR #2869 because I don't really know if this is the right fix. Note that the value is set to False because that is the default.

Testing Instructions

As this PR aims to fix CI failures, CI should pass.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions github-actions bot added the 🧱 stack: catalog Related to the catalog and Airflow DAGs label Aug 23, 2023
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Aug 23, 2023
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 23, 2023
@dhruvkb dhruvkb marked this pull request as ready for review August 23, 2023 23:04
@dhruvkb dhruvkb requested a review from a team as a code owner August 23, 2023 23:04
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this param does not exist in the previous airflow versions, adding it in a PR to the dependabot PR seems correct.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, I was able to confirm tests look good locally after building!

@dhruvkb dhruvkb merged commit cb352f2 into dependabot/pip/catalog/apache-airflow-amazonhttppostgres--2.7.0 Aug 29, 2023
78 checks passed
@dhruvkb dhruvkb deleted the fix_airflow_upgrade branch August 29, 2023 05:23
stacimc pushed a commit that referenced this pull request Aug 29, 2023
…alog (#2869)

* Bump apache-airflow[amazon,http,postgres] in /catalog

Bumps [apache-airflow[amazon,http,postgres]](https://github.com/apache/airflow) from 2.6.3 to 2.7.0.
- [Release notes](https://github.com/apache/airflow/releases)
- [Changelog](https://github.com/apache/airflow/blob/main/RELEASE_NOTES.rst)
- [Commits](apache/airflow@2.6.3...2.7.0)

---
updated-dependencies:
- dependency-name: apache-airflow[amazon,http,postgres]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add missing argument in `Pool.create_or_update_pool` (#2876)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dhruv Bhanushali <hi@dhruvkb.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants