Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectively update API deps and undo unrelated updates #4002

Merged
merged 4 commits into from Apr 1, 2024
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Apr 1, 2024

Description

This PR undoes recent dependency bumps in the API, and updates the following dependencies selectively (using pipenv upgrade <package_name> which doesn't update unrelated packages).

  • elasticsearch
  • fakeredis

Testing Instructions

Test that the API continues to work normally, the CI checks should cover that.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix dependencies Pull requests that update a dependency file 🐍 tech: python Involves Python 🧱 stack: api Related to the Django API labels Apr 1, 2024
@dhruvkb dhruvkb changed the title Reset api deps Selectively update API deps and undo unrelated updates Apr 1, 2024
@dhruvkb dhruvkb requested a review from a team as a code owner April 1, 2024 20:48
@AetherUnbound AetherUnbound added 💻 aspect: code Concerns the software code in the repository 🟥 priority: critical Must be addressed ASAP and removed 🟧 priority: high Stalls work on the project or its dependents labels Apr 1, 2024
@dhruvkb dhruvkb requested a review from a team as a code owner April 1, 2024 21:42
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diving into those changes! I tried doing some load testing locally but found that the port was outdated, so I went ahead and updated it as part of this PR too. That wasn't able to uncover any issues on main either, FWIW though.

@dhruvkb dhruvkb merged commit 3e99702 into main Apr 1, 2024
43 checks passed
@dhruvkb dhruvkb deleted the reset_api_deps branch April 1, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: api Related to the Django API 🐍 tech: python Involves Python
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants