Fix string decoding in the frontend

[obulat]

Fixes

Fixes #4125 by @obulat

Description

This PR updates the decode-data function to not convert the character combinations that are not URI-encodable.

Some tags contain incorrectly encoded tag names without the backslash for u-encoded characters. We compensate for that in the frontend by converting them correctly to unicode characters. However, there's an edge case where the combinations of characters such as udada are considered as incorrectly-encoded sequence of characters, but the result is a symbol that is not valid in a URL, so when we try to create a tag URL from it in a single result page, the page shows an error.

We will move the tag cleanup from the frontend to the data cleanup process in the future, but for now, to fix the Nuxt server error page¹, we need to add a hot-fix in the frontend.

Update: this will also fix the incorrectly decoded titles and other decoded strings. See, for instance, https://openverse.org/image/9cda415c-c4d1-4650-9e1e-0f92b5f8d772?q=ciudada : the title and the attribution have incorrectly displayed characters that replace "udada" in the word "ciudada".

Testing Instructions

Run the app using just frontend/run dev:only
Open http://localhost:8443/image/076a0436-1d9e-449a-a224-01301f4d8c8e
You should see the page loaded correctly.

Go to http://localhost:8443/image/9cda415c-c4d1-4650-9e1e-0f92b5f8d772?q=ciudada . You should not see un-printable characters as you do in prod.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Footnotes

1. udada in "ciudada" in tags for item https://api.openverse.engineering/v1/images/076a0436-1d9e-449a-a224-01301f4d8c8e/ causes a Nuxt server error: https://openverse.org/image/076a0436-1d9e-449a-a224-01301f4d8c8e ↩

[AetherUnbound]

I'm not quite sure I understand all the logic here with the regex replacement, but I've confirmed I'm not able to reproduce the issue locally!

[AetherUnbound]

Do we not need to have a similar case for \x characters?

[obulat]

No, that kind of encoding/decoding error never happened :)

[openverse-bot]

Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR:

@zackkrida
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend¹ days, this PR was ready for review 4 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)².

@obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

1. Specifically, Saturday and Sunday. ↩

2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

[zackkrida]

Oops, meant to have already approved this. LGTM.