-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate utilities/generate_test_locales
to PDM
#4626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One blocking comment, but also we need to delete the Pipfile and Pipfile.lock.
4ed0cfb
to
1c7d453
Compare
1c7d453
to
404b980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I get a minor change among locales update for ar
and es
, but besides that, looks good!
e83d40e
to
7e0d9a0
Compare
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
7e0d9a0
to
7bce6a8
Compare
Fixes
Related to #4166 by @dhruvkb
Description
This PR migrates the
generate_test_locales
to PDM.Testing Instructions
Run
./ov just utilities/generate_test_locales/install
and./ov just utilities/generate_test_locales/run
See that the translation files in
frontend/test
are updated.Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin