Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate utilities/generate_test_locales to PDM #4626

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jul 17, 2024

Fixes

Related to #4166 by @dhruvkb

Description

This PR migrates the generate_test_locales to PDM.

Testing Instructions

Run ./ov just utilities/generate_test_locales/install and ./ov just utilities/generate_test_locales/run
See that the translation files in frontend/test are updated.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: mgmt Related to repo management and automations labels Jul 17, 2024
@obulat obulat self-assigned this Jul 17, 2024
@obulat obulat requested a review from a team as a code owner July 17, 2024 08:50
@obulat obulat mentioned this pull request Jul 17, 2024
15 tasks
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocking comment, but also we need to delete the Pipfile and Pipfile.lock.

utilities/generate_test_locales/justfile Outdated Show resolved Hide resolved
@obulat obulat force-pushed the pdm/utilities/generate_test_locales branch from 4ed0cfb to 1c7d453 Compare July 18, 2024 10:46
@obulat obulat force-pushed the pdm/utilities/generate_test_locales branch from 1c7d453 to 404b980 Compare July 18, 2024 11:17
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I get a minor change among locales update for ar and es, but besides that, looks good!

utilities/generate_test_locales/pdm.lock Outdated Show resolved Hide resolved
@obulat obulat dismissed sarayourfriend’s stale review July 19, 2024 05:30

The requested change was added

@obulat obulat requested a review from a team as a code owner July 19, 2024 05:38
@obulat obulat requested a review from zackkrida July 19, 2024 05:38
@obulat obulat force-pushed the pdm/utilities/generate_test_locales branch from e83d40e to 7e0d9a0 Compare July 23, 2024 03:57
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat force-pushed the pdm/utilities/generate_test_locales branch from 7e0d9a0 to 7bce6a8 Compare July 23, 2024 05:51
@obulat obulat merged commit 7cfb689 into main Jul 23, 2024
46 checks passed
@obulat obulat deleted the pdm/utilities/generate_test_locales branch July 23, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants