Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always build both api & ingestion server images for either service #936

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Always build both api & ingestion server images for either service #936

merged 2 commits into from
Mar 17, 2023

Conversation

AetherUnbound
Copy link
Contributor

Description

This is a follow up to #925 which is currently affecting #933, #934, and #935. The ingestion server is also necessary for API tests, so we must unconditionally build it when only the API code is changed.

This PR modifies the logic so that the API and ingestion server images are always built for either API or ingestion server changes, only publish behavior is now affected by which service has been affected.

Testing Instructions

Based on this file being changed all services will change so we won't be able to test this on this PR, but hopefully once merged we will see it work on any of the above PRs.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner March 17, 2023 00:09
@AetherUnbound AetherUnbound added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix labels Mar 17, 2023
@AetherUnbound AetherUnbound added 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Mar 17, 2023
@github-actions github-actions bot added 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: frontend Related to the Nuxt frontend labels Mar 17, 2023
@github-actions
Copy link

github-actions bot commented Mar 17, 2023 •
edited
Loading

Size Change: 0 B

Total Size: 878 kB

ℹ️ View Unchanged
Filename Size
./frontend/.nuxt/dist/client/235.js 273 B
./frontend/.nuxt/dist/client/235.modern.js 277 B
./frontend/.nuxt/dist/client/236.js 1.85 kB
./frontend/.nuxt/dist/client/app.js 143 kB
./frontend/.nuxt/dist/client/app.modern.js 117 kB
./frontend/.nuxt/dist/client/commons/app.js 87.8 kB
./frontend/.nuxt/dist/client/commons/app.modern.js 78.2 kB
./frontend/.nuxt/dist/client/components/loading-icon.js 746 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 753 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 514 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 519 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 8.02 kB
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 5.48 kB
./frontend/.nuxt/dist/client/components/v-audio-cell.js 392 B
./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js 396 B
./frontend/.nuxt/dist/client/components/v-audio-details.js 2.55 kB
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.79 kB
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 1.02 kB
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.23 kB
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.17 kB
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 542 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 547 B
./frontend/.nuxt/dist/client/components/v-bone.js 693 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 697 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.24 kB
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.24 kB
./frontend/.nuxt/dist/client/components/v-content-link.js 1.12 kB
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.1 kB
./frontend/.nuxt/dist/client/components/v-content-page.js 526 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 530 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 786 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 789 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 6.11 kB
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.59 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 1.24 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 4.25 kB
./frontend/.nuxt/dist/client/components/v-copy-button.js 4 kB
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4.01 kB
./frontend/.nuxt/dist/client/components/v-copy-license.js 1 kB
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js 9.95 kB
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js 9.93 kB
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 754 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 759 B
./frontend/.nuxt/dist/client/components/v-error-image.js 1.7 kB
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 1.69 kB
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 376 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 1.92 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.92 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.js 903 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 907 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.52 kB
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.52 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.62 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.63 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.8 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.8 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.76 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.73 kB
./frontend/.nuxt/dist/client/components/v-image-carousel.js 4.73 kB
./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js 4.71 kB
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.57 kB
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.56 kB
./frontend/.nuxt/dist/client/components/v-image-details.js 2.17 kB
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.99 kB
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 2.52 kB
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 526 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 529 B
./frontend/.nuxt/dist/client/components/v-load-more.js 3.17 kB
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 694 B
./frontend/.nuxt/dist/client/components/v-media-license.js 827 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 836 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 1.63 kB
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 1.63 kB
./frontend/.nuxt/dist/client/components/v-media-tag.js 435 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 438 B
./frontend/.nuxt/dist/client/components/v-modal.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-modal.modern.js 995 B
./frontend/.nuxt/dist/client/components/v-no-results.js 757 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 756 B
./frontend/.nuxt/dist/client/components/v-radio.js 1.51 kB
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.47 kB
./frontend/.nuxt/dist/client/components/v-related-audio.js 1.26 kB
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 1.27 kB
./frontend/.nuxt/dist/client/components/v-related-images.js 1.06 kB
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 3.09 kB
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 981 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.71 kB
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.72 kB
./frontend/.nuxt/dist/client/components/v-scroll-button.js 825 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 830 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 5.75 kB
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 5.68 kB
./frontend/.nuxt/dist/client/components/v-search-results-title.js 599 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 605 B
./frontend/.nuxt/dist/client/components/v-search-type-radio.js 805 B
./frontend/.nuxt/dist/client/components/v-search-type-radio.modern.js 781 B
./frontend/.nuxt/dist/client/components/v-server-timeout.js 299 B
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 303 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 3.4 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 912 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.19 kB
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB
./frontend/.nuxt/dist/client/components/v-sources-table.js 16.2 kB
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 16.2 kB
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B
./frontend/.nuxt/dist/client/pages/about.js 1.4 kB
./frontend/.nuxt/dist/client/pages/about.modern.js 1.4 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 8.02 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 4.86 kB
./frontend/.nuxt/dist/client/pages/external-sources.js 1.56 kB
./frontend/.nuxt/dist/client/pages/external-sources.modern.js 1.56 kB
./frontend/.nuxt/dist/client/pages/feedback.js 1.34 kB
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.34 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.js 9.32 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 5.18 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.js 3.65 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.25 kB
./frontend/.nuxt/dist/client/pages/index.js 6.9 kB
./frontend/.nuxt/dist/client/pages/index.modern.js 6.84 kB
./frontend/.nuxt/dist/client/pages/preferences.js 1.32 kB
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.32 kB
./frontend/.nuxt/dist/client/pages/privacy.js 1.01 kB
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.02 kB
./frontend/.nuxt/dist/client/pages/search-help.js 1.6 kB
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.58 kB
./frontend/.nuxt/dist/client/pages/search.js 4.56 kB
./frontend/.nuxt/dist/client/pages/search.modern.js 2.04 kB
./frontend/.nuxt/dist/client/pages/search/audio.js 6.03 kB
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 3.54 kB
./frontend/.nuxt/dist/client/pages/search/image.js 508 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 2.7 kB
./frontend/.nuxt/dist/client/pages/search/index.js 443 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 447 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 243 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.js 266 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B
./frontend/.nuxt/dist/client/pages/sources.js 1.57 kB
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.57 kB
./frontend/.nuxt/dist/client/runtime.js 2.72 kB
./frontend/.nuxt/dist/client/runtime.modern.js 2.73 kB
./frontend/.nuxt/dist/client/vendors/app.js 63.3 kB
./frontend/.nuxt/dist/client/vendors/app.modern.js 62.3 kB

compressed-size-action

@zackkrida zackkrida merged commit 94c1c4d into main Mar 17, 2023
@zackkrida zackkrida deleted the hotfix/build-ingestion-server-ci branch March 17, 2023 00:28
@github-actions
Copy link

github-actions bot commented Mar 17, 2023 •
edited
Loading

Full-stack documentation: Ready

https://WordPress.github.io/openverse/_preview/936

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krysal krysal krysal approved these changes

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@stacimc stacimc Awaiting requested review from stacimc stacimc is a code owner automatically assigned from WordPress/openverse-maintainers

Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: api Related to the Django API 🧱 stack: frontend Related to the Nuxt frontend 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: mgmt Related to repo management and automations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AetherUnbound @krysal @sarayourfriend @zackkrida