Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmatched parentheses in i18n check break the regex #3

Closed
Otto42 opened this issue Oct 31, 2014 · 1 comment
Closed

Unmatched parentheses in i18n check break the regex #3

Otto42 opened this issue Oct 31, 2014 · 1 comment
Labels

Comments

@Otto42
Copy link
Member

Otto42 commented Oct 31, 2014

Reported here:
https://wordpress.org/support/topic/bug-i-guess?replies=2#post-6175594

Example:
_e( 'text field (you can leave it blank', 'mytheme' );

Likely solution: tokenize the whole file instead of just that line. Similar to the patch for this:
#1

@Otto42
Copy link
Member Author

Otto42 commented Feb 24, 2015

Given the speed problems this already has, no. Let it break. Maybe detect it and fail themes that are doing it, but strings in translation need to be complete, not partial. Wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant