Add dash to regex and fix typo (Fixes #114) #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress#115" This reverts commit bf1bc47.
|
Generally speaking, you make a new "branch" for each separate "thing" that you're working on. This is because when you submit a PR, then you're submitting all the changes in that whole branch. Updating the branch later updates the PR as well. Thus, each branch should consist of one whole change for one specific purpose. Reverting the other change is fine at this time. For the future, just so you know, when you want to work on an unrelated thing, switch back to the master, then branch from there for the new thing to be worked on. Keeps changes separate. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not a Git guru, so I just reverted the unnecessary commit. Fine? Or what should I do to split this up?