This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Revert toolbar positioning. #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #665. This PR reverts the customization to the toolbar for wide and fullwide. It doesn't look quite as good, but it makes the block mover usable again. Let's look at some upstream improvements instead, I have a few ideas.
kjellr
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
Sounds good. Let's take this out for now. 👍
One thing to note before we merge: Because our alignwide blocks are left-aligned with the content, the move controls will overlap the content a bit:
😕 At least they're available with this PR though. So I think that's an improvement.
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Dec 14, 2018
This update changes the following: - Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: WordPress/twentynineteen#668 - Add nowrap to the columns block at breakpoints above 600px. More info here: WordPress/twentynineteen#674 Props joen, kjellr. Fixes #45369. See #45424. git-svn-id: https://develop.svn.wordpress.org/branches/5.0@44189 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Dec 15, 2018
This update changes the following: - Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: WordPress/twentynineteen#668 - Add nowrap to the columns block at breakpoints above 600px. More info here: WordPress/twentynineteen#674 Props joen, kjellr. Fixes #45369. See #45424. Built from https://develop.svn.wordpress.org/branches/5.0@44189 git-svn-id: http://core.svn.wordpress.org/branches/5.0@44019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Dec 15, 2018
This update changes the following: - Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: WordPress/twentynineteen#668 - Add nowrap to the columns block at breakpoints above 600px. More info here: WordPress/twentynineteen#674 Props joen, kjellr. Fixes #45369. See #45424. Built from https://develop.svn.wordpress.org/branches/5.0@44189 git-svn-id: https://core.svn.wordpress.org/branches/5.0@44019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
nylen
pushed a commit
to nylen/wordpress-develop-svn
that referenced
this pull request
Dec 18, 2018
This update changes the following: - Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: WordPress/twentynineteen#668 - Add `nowrap` to the columns block at breakpoints above `600px`. More info here: WordPress/twentynineteen#674 Props joen, kjellr, allancole. Fixes #45369. Merges [44189] into trunk. See #45424. git-svn-id: https://develop.svn.wordpress.org/trunk@44300 602fd350-edb4-49c9-b593-d223f7449a82
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Dec 18, 2018
This update changes the following: - Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: WordPress/twentynineteen#668 - Add `nowrap` to the columns block at breakpoints above `600px`. More info here: WordPress/twentynineteen#674 Props joen, kjellr, allancole. Fixes #45369. Merges [44189] into trunk. See #45424. git-svn-id: https://develop.svn.wordpress.org/trunk@44300 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Dec 19, 2018
This update changes the following: - Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: WordPress/twentynineteen#668 - Add `nowrap` to the columns block at breakpoints above `600px`. More info here: WordPress/twentynineteen#674 Props joen, kjellr, allancole. Fixes #45369. Merges [44189] into trunk. See #45424. Built from https://develop.svn.wordpress.org/trunk@44300 git-svn-id: http://core.svn.wordpress.org/trunk@44130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Dec 19, 2018
This update changes the following: - Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: WordPress/twentynineteen#668 - Add `nowrap` to the columns block at breakpoints above `600px`. More info here: WordPress/twentynineteen#674 Props joen, kjellr, allancole. Fixes #45369. Merges [44189] into trunk. See #45424. Built from https://develop.svn.wordpress.org/trunk@44300 git-svn-id: https://core.svn.wordpress.org/trunk@44130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
svn2github
pushed a commit
to svn2github/wp-svn-2-git
that referenced
this pull request
Dec 21, 2018
This update changes the following: - Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: WordPress/twentynineteen#668 - Add `nowrap` to the columns block at breakpoints above `600px`. More info here: WordPress/twentynineteen#674 Props joen, kjellr, allancole. Fixes #45369. Merges [44189] into trunk. See #45424. Built from https://develop.svn.wordpress.org/trunk@44300 git-svn-id: http://core.svn.wordpress.org/trunk@44130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #665.
This PR reverts the customization to the toolbar for wide and fullwide.
It doesn't look quite as good, but it makes the block mover usable again.
Let's look at some upstream improvements instead, I have a few ideas.