Skip to content
This repository has been archived by the owner on Dec 1, 2019. It is now read-only.

Add missing roles to <nav> elements #693

Merged
merged 4 commits into from
Oct 2, 2019
Merged

Add missing roles to <nav> elements #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f89980b
Add missing roles to <nav> elements
Oct 1, 2019
ffe4f25
Merge branch 'master' into fix/add-navigation-roles
nielslange Oct 1, 2019
71e445e
Merge branch 'master' into fix/add-navigation-roles
carolinan Oct 1, 2019
a7c8e5a
Merge branch 'master' into fix/add-navigation-roles
nielslange Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions template-parts/modal-menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

?>

<nav class="expanded-menu<?php echo esc_attr( $expanded_nav_classes ); ?>" aria-label="<?php esc_attr_e( 'Expanded', 'twentytwenty' ); ?>">
<nav class="expanded-menu<?php echo esc_attr( $expanded_nav_classes ); ?>" aria-label="<?php esc_attr_e( 'Expanded', 'twentytwenty' ); ?>" role="navigation">

<ul class="modal-menu reset-list-style">
<?php
Expand All @@ -70,7 +70,7 @@
if ( 'expanded' !== $mobile_menu_location ) {
?>

<nav class="mobile-menu" aria-label="<?php esc_attr_e( 'Mobile', 'twentytwenty' ); ?>">
<nav class="mobile-menu" aria-label="<?php esc_attr_e( 'Mobile', 'twentytwenty' ); ?>" role="navigation">

<ul class="modal-menu reset-list-style">

Expand Down Expand Up @@ -114,7 +114,7 @@

<?php if ( has_nav_menu( 'social' ) ) { ?>

<nav aria-label="<?php esc_attr_e( 'Expanded Social links', 'twentytwenty' ); ?>">
<nav aria-label="<?php esc_attr_e( 'Expanded Social links', 'twentytwenty' ); ?>" role="navigation">
<ul class="social-menu reset-list-style social-icons s-icons">

<?php
Expand Down
2 changes: 1 addition & 1 deletion template-parts/navigation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

?>

<nav class="pagination-single section-inner<?php echo esc_attr( $pagination_classes ); ?>" aria-label="<?php esc_attr_e( 'Post', 'twentytwenty' ); ?>">
<nav class="pagination-single section-inner<?php echo esc_attr( $pagination_classes ); ?>" aria-label="<?php esc_attr_e( 'Post', 'twentytwenty' ); ?>" role="navigation">

<hr class="styled-separator is-style-wide" aria-hidden="true" />

Expand Down