Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Consider new block patterns #172

Closed
kjellr opened this issue Oct 28, 2021 · 10 comments · Fixed by #211
Closed

Consider new block patterns #172

kjellr opened this issue Oct 28, 2021 · 10 comments · Fixed by #211
Assignees
Labels
[Type] Enhancement New feature or request
Milestone

Comments

@kjellr
Copy link
Collaborator

kjellr commented Oct 28, 2021

We added the originally designed block patterns already, but I'd like to leave open the door for some more. This issue will serve a place to track that work.

I'd specifically like to add more of the poster-like "Page" patterns, since we only have a few of those:

136080878-6bbad782-dbd1-4f11-bc59-6ac361e49fd2

@kjellr kjellr added the [Type] Enhancement New feature or request label Oct 28, 2021
@kjellr kjellr added this to the Beta 1 milestone Oct 28, 2021
@kjellr kjellr self-assigned this Oct 28, 2021
@beafialho
Copy link

Here are a few suggestions. I tried a couple different background colors and took the liberty of adding some names/content.

Page Layout-1

Page Layout-2

Page Layout-3

Page Layout-4

Page Layout

@kjellr
Copy link
Collaborator Author

kjellr commented Oct 28, 2021

Cool, thanks @beafialho! I'll try building a few of these out to see how they work. 👍

@kjellr
Copy link
Collaborator Author

kjellr commented Nov 1, 2021

Just a quick update:

  • I began building that first one, but had a hard time getting the image resized down to something reasonable. Will give it another try tomorrow.
  • The next two might be a bit problematic because the editor currently lacks support for changing the font family for paragraph blocks. In both of those patterns, the names are in Source Serif, but they are content, not headings. I'm not quite sure of a great way around this yet, but I may end up filing a Gutenberg issue or two in the meantime.

@kjellr
Copy link
Collaborator Author

kjellr commented Nov 3, 2021

A couple other ideas:

  • We had to cut the right-sidebar pattern from Add sidebar patterns #164. It didn't work with the content as designed, but I think we could easily design a pattern that does. It would be great to have a right-sidebar pattern represented in the set.
  • Our header patterns are overwhelmingly white and similar. I'd like to try varying those a little bit more.

@beafialho
Copy link

The next two might be a bit problematic because the editor currently lacks support for changing the font family for paragraph blocks. In both of those patterns, the names are in Source Serif, but they are content, not headings. I'm not quite sure of a great way around this yet, but I may end up filing a Gutenberg issue or two in the meantime.

I see. I can also try to redesign these using the paragraph font.

Our header patterns are overwhelmingly white and similar. I'd like to try varying those a little bit more.

Working on some colourful header patterns at the moment, will post them here soon.

@beafialho
Copy link

For headers, here are some suggestions with color.

Header-7

Header-5

Header-4

Header-3

Header

And a few using images in the header's backgrounds, as suggested in #184.

Header-1

Header-6

Header-2

I also redid the two patterns that weren't viable to achieve with Source Serif, they seem to work pretty well with the paragraphs font.

Page Layout-1
Page Layout

@kjellr
Copy link
Collaborator Author

kjellr commented Nov 3, 2021

🎉 These are wonderful, thanks @beafialho. I'll try building these later this week.

@carolinan
Copy link
Collaborator

The green header with background image looks amazing.

The header with the bird image might be tricky, I tried something similar but depending on screen width and number of menu items, the menu text overlaps the graphics in a way that makes the text difficult to read.

@beafialho
Copy link

Definitely @carolinan, I was hesitant with that one too. It's probably more prudent to keep more abstract images in the header. If there's a more opaque overlay, it could work:

Mobile

@kjellr
Copy link
Collaborator Author

kjellr commented Nov 4, 2021

I think it's worth including anyway. If necessary, we can suggest an ideal number of menu items for the header, just like we do for this one:

Screen Shot 2021-11-04 at 7 56 35 AM

I'll try build these today, as additions to #204.

@jffng jffng closed this as completed in #211 Nov 5, 2021
jeffpaul added a commit to jeffpaul/twentytwentytwo that referenced this issue Nov 16, 2021
Note that some of the references below are not the only contributions (commits, PR review, helpful issue input, etc.) from these folks, but merely the first ones I encountered while reviewing items committed to `trunk` since the initial branch commit.

@westonruter via  WordPress#51
@ntwb via WordPress#73
@juricav via WordPress#113
@Sandstromer via WordPress#69
@jasmussen via WordPress#74
@melchoyce via WordPress#16
@Riyadh1734 via WordPress#182
@desrosj via WordPress#223
@beafialho via WordPress#172
@clucasrowlands via WordPress#171
@Otto42 via WordPress#28
@luminuu via WordPress#107
@felixarntz via WordPress#240
kjellr added a commit that referenced this issue Nov 17, 2021
* add missing props to CONTRIBUTORS.md

Note that some of the references below are not the only contributions (commits, PR review, helpful issue input, etc.) from these folks, but merely the first ones I encountered while reviewing items committed to `trunk` since the initial branch commit.

@westonruter via  #51
@ntwb via #73
@juricav via #113
@Sandstromer via #69
@jasmussen via #74
@melchoyce via #16
@Riyadh1734 via #182
@desrosj via #223
@beafialho via #172
@clucasrowlands via #171
@Otto42 via #28
@luminuu via #107
@felixarntz via #240

* add dotorg handles to CONTRIBUTORS.md

* Fix Rich's WP.org username.

Co-authored-by: Kjell Reigstad <kjell@kjellr.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants