Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's Encrypt: Only request certificates for WordCamp sites #915

Merged
merged 1 commit into from Jun 21, 2023

Conversation

iandunn
Copy link
Member

@iandunn iandunn commented Jun 21, 2023

Sites on the new Events network will use the wordpress.org wildcard SSL.

See #906

prepare() is used because in a future commit 1 will be replaced with EVENTS_NETWORK_ID. See #907.

This needs to be deployed before #907, because creating the events.wordpress.org site triggered a Nagios alert from the Dehydrated client.

xref Slack G0B1CF7E1/p1687372885952129

Sites on the new Events network will use the `wordpress.org` wildcard SSL.

See #906

`prepare()` is used because in a future commit `1` will be replaced with `EVENTS_NETWORK_ID`. See #907.
@iandunn iandunn self-assigned this Jun 21, 2023
@iandunn iandunn added this to the Pilot Events: MVP milestone Jun 21, 2023
@iandunn
Copy link
Member Author

iandunn commented Jun 21, 2023

The test failures look like a problem with the test suite rather than an actual bug, so I'm gonna go ahead and deploy this to fix production.

I'll circle back later to fix the tests.

@iandunn iandunn marked this pull request as ready for review June 21, 2023 19:29
@iandunn iandunn merged commit 0edf7ab into production Jun 21, 2023
2 of 3 checks passed
@iandunn iandunn deleted the letsencrypt-wordcamp-only branch June 21, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant