PHP 8.2 | GH Actions: start running the unit tests against PHP 8.2 #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes:
* The `composer install` for PHP 8.1 was still using `--ignore-platform-reqs`, while that hasn't been needed anymore for quite a while, so I'm just re-using the condition for PHP 8.2 now.
* I've also made the `--ignore-platform...` option used for the install more specific.
Composer 2.0 added a `--ignore-platform-req=...` option to selectively ignore platform requirements.
Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the `+` sign.
* As discussed for PHP 8.1, builds against PHP 8.2 will still be allowed to fail (and will fail, not just due to new PHP 8.2 issues, but also due to unsolved PHP 8.1 issues). Allowing those builds to fail prevents merges in the Gutenberg project becoming blocked.
* As for the Xdebug related tests: those will not be run on PHP 8.2 yet as the Docker image for PHP 8.2 does not contain Xdebug yet. Once a stable release of Xdebug 3.2.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.2.
Refs:
* WordPress/wpdev-docker-images#87
* https://github.com/composer/composer/releases/tag/2.0.0
* https://github.com/composer/composer/releases/tag/2.2.0
* https://xdebug.org/announcements/2022-07-20
* https://xdebug.org/announcements/2022-07-25
|
Previous similar ticket for PHP 8.1: https://core.trac.wordpress.org/ticket/53891 |
|
Thanks for the PR! Merged in r53922. |
|
Thank you @SergeyBiryukov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
composer installfor PHP 8.1 was still using--ignore-platform-reqs, while that hasn't been needed anymore for quite a while, so I'm just re-using the condition for PHP 8.2 now.--ignore-platform...option used for the install more specific.Composer 2.0 added a
--ignore-platform-req=...option to selectively ignore platform requirements.Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the
+sign.Refs:
Trac ticket: https://core.trac.wordpress.org/ticket/56009
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.