Add PHP 8.2 containers #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, use the 8.2-rc container.
|
I'm not sure PHPUnit should be included yet as they have not officially declared PHP 8.2 compatibility yet, let alone which versions will be supported. |
|
@jrfnl I'm fine either way! My thinking for including them was that PHPUnit does test against PHP 8.2 in their CI even though support is not declared. |
|
P.S.: I'm not the right person to review as I don't use Docker myself. |
|
I've tested all of the generated containers, and everything seems right to me. The test suite does run using both PHPUnit 8.x and 9.x (of course with errors and failures). Even though it hasn't officially been declared which versions will support PHP 8.2, I think it's reasonable to make both versions available since PHPUnit itself is currently testing against 8.2. |
|
For anyone interested, here is the meta ticket about making WordPress compatible with PHP 8.2: https://core.trac.wordpress.org/ticket/56009 |
|
FYI: Xdebug 3.2.0 will be compatible with PHP 8.2 and alpha builds are available for testing at the moment: https://xdebug.org/download/historical Also see: |
jrfnl
added a commit
to jrfnl/wordpress-develop-official
that referenced
this pull request
Aug 23, 2022
Notes:
* The `composer install` for PHP 8.1 was still using `--ignore-platform-reqs`, while that hasn't been needed anymore for quite a while, so I'm just re-using the condition for PHP 8.2 now.
* I've also made the `--ignore-platform...` option used for the install more specific.
Composer 2.0 added a `--ignore-platform-req=...` option to selectively ignore platform requirements.
Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the `+` sign.
* As discussed for PHP 8.1, builds against PHP 8.2 will still be allowed to fail (and will fail, not just due to new PHP 8.2 issues, but also due to unsolved PHP 8.1 issues). Allowing those builds to fail prevents merges in the Gutenberg project becoming blocked.
* As for the Xdebug related tests: those will not be run on PHP 8.2 yet as the Docker image for PHP 8.2 does not contain Xdebug yet. Once a stable release of Xdebug 3.2.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.2.
Refs:
* WordPress/wpdev-docker-images#87
* https://github.com/composer/composer/releases/tag/2.0.0
* https://github.com/composer/composer/releases/tag/2.2.0
* https://xdebug.org/announcements/2022-07-20
* https://xdebug.org/announcements/2022-07-25
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 23, 2022
PHP 8.2 is expected to be released at the end of November 2022. Enabling the tests to run in CI on PHP 8.2 allows WordPress core to start getting ready. As an interim measure, while working through the PHP 8.1 and 8.2 issues, builds against these PHP versions are allowed to fail, so that they don't block PR merges in the Gutenberg project. Notes: * The `composer install` command for PHP 8.1 was still using the `--ignore-platform-reqs` option, while that has not been needed anymore for quite a while, so the condition is now reused for PHP 8.2. * The `--ignore-platform...` option used for the install is now made more specific: * Composer 2.0 added a `--ignore-platform-req=...` option to selectively ignore platform requirements. * Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the `+` sign. * Xdebug-related tests will not be run on PHP 8.2 at this time as the Docker image for PHP 8.2 does not contain Xdebug yet. Once a stable release of Xdebug 3.2.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.2. References: * [WordPress/wpdev-docker-images#87 wpdev-docker-images PR #87: Add PHP 8.2 containers] * [https://github.com/composer/composer/releases/tag/2.0.0 Composer 2.0 changelog] * [https://github.com/composer/composer/releases/tag/2.2.0 Composer 2.2 changelog] * [https://xdebug.org/announcements/2022-07-20 Xdebug 3.2.0alpha1 release notes] * [https://xdebug.org/announcements/2022-07-25 Xdebug 3.2.0alpha2 release notes] Follow-up to [49077], [49162], [50299], [51588], [51604]. Props jrf, desrosj. See #56009. Built from https://develop.svn.wordpress.org/trunk@53922 git-svn-id: http://core.svn.wordpress.org/trunk@53481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott
pushed a commit
to gMagicScott/core.wordpress-mirror
that referenced
this pull request
Aug 23, 2022
PHP 8.2 is expected to be released at the end of November 2022. Enabling the tests to run in CI on PHP 8.2 allows WordPress core to start getting ready. As an interim measure, while working through the PHP 8.1 and 8.2 issues, builds against these PHP versions are allowed to fail, so that they don't block PR merges in the Gutenberg project. Notes: * The `composer install` command for PHP 8.1 was still using the `--ignore-platform-reqs` option, while that has not been needed anymore for quite a while, so the condition is now reused for PHP 8.2. * The `--ignore-platform...` option used for the install is now made more specific: * Composer 2.0 added a `--ignore-platform-req=...` option to selectively ignore platform requirements. * Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the `+` sign. * Xdebug-related tests will not be run on PHP 8.2 at this time as the Docker image for PHP 8.2 does not contain Xdebug yet. Once a stable release of Xdebug 3.2.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.2. References: * [WordPress/wpdev-docker-images#87 wpdev-docker-images PR #87: Add PHP 8.2 containers] * [https://github.com/composer/composer/releases/tag/2.0.0 Composer 2.0 changelog] * [https://github.com/composer/composer/releases/tag/2.2.0 Composer 2.2 changelog] * [https://xdebug.org/announcements/2022-07-20 Xdebug 3.2.0alpha1 release notes] * [https://xdebug.org/announcements/2022-07-25 Xdebug 3.2.0alpha2 release notes] Follow-up to [49077], [49162], [50299], [51588], [51604]. Props jrf, desrosj. See #56009. Built from https://develop.svn.wordpress.org/trunk@53922 git-svn-id: https://core.svn.wordpress.org/trunk@53481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pbearne
pushed a commit
to pbearne/wordpress-develop
that referenced
this pull request
Sep 9, 2022
PHP 8.2 is expected to be released at the end of November 2022. Enabling the tests to run in CI on PHP 8.2 allows WordPress core to start getting ready. As an interim measure, while working through the PHP 8.1 and 8.2 issues, builds against these PHP versions are allowed to fail, so that they don't block PR merges in the Gutenberg project. Notes: * The `composer install` command for PHP 8.1 was still using the `--ignore-platform-reqs` option, while that has not been needed anymore for quite a while, so the condition is now reused for PHP 8.2. * The `--ignore-platform...` option used for the install is now made more specific: * Composer 2.0 added a `--ignore-platform-req=...` option to selectively ignore platform requirements. * Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the `+` sign. * Xdebug-related tests will not be run on PHP 8.2 at this time as the Docker image for PHP 8.2 does not contain Xdebug yet. Once a stable release of Xdebug 3.2.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.2. References: * [WordPress/wpdev-docker-images#87 wpdev-docker-images PR #87: Add PHP 8.2 containers] * [https://github.com/composer/composer/releases/tag/2.0.0 Composer 2.0 changelog] * [https://github.com/composer/composer/releases/tag/2.2.0 Composer 2.2 changelog] * [https://xdebug.org/announcements/2022-07-20 Xdebug 3.2.0alpha1 release notes] * [https://xdebug.org/announcements/2022-07-25 Xdebug 3.2.0alpha2 release notes] Follow-up to [49077], [49162], [50299], [51588], [51604]. Props jrf, desrosj. See #56009. git-svn-id: https://develop.svn.wordpress.org/trunk@53922 602fd350-edb4-49c9-b593-d223f7449a82
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
PHP 8.2 is expected to be released at the end of November 2022. Enabling the tests to run in CI on PHP 8.2 allows WordPress core to start getting ready. As an interim measure, while working through the PHP 8.1 and 8.2 issues, builds against these PHP versions are allowed to fail, so that they don't block PR merges in the Gutenberg project. Notes: * The `composer install` command for PHP 8.1 was still using the `--ignore-platform-reqs` option, while that has not been needed anymore for quite a while, so the condition is now reused for PHP 8.2. * The `--ignore-platform...` option used for the install is now made more specific: * Composer 2.0 added a `--ignore-platform-req=...` option to selectively ignore platform requirements. * Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the `+` sign. * Xdebug-related tests will not be run on PHP 8.2 at this time as the Docker image for PHP 8.2 does not contain Xdebug yet. Once a stable release of Xdebug 3.2.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.2. References: * [WordPress/wpdev-docker-images#87 wpdev-docker-images PR #87: Add PHP 8.2 containers] * [https://github.com/composer/composer/releases/tag/2.0.0 Composer 2.0 changelog] * [https://github.com/composer/composer/releases/tag/2.2.0 Composer 2.2 changelog] * [https://xdebug.org/announcements/2022-07-20 Xdebug 3.2.0alpha1 release notes] * [https://xdebug.org/announcements/2022-07-25 Xdebug 3.2.0alpha2 release notes] Follow-up to [49077], [49162], [50299], [51588], [51604]. Props jrf, desrosj. See #56009. Built from https://develop.svn.wordpress.org/trunk@53922
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
PHP 8.2 is expected to be released at the end of November 2022. Enabling the tests to run in CI on PHP 8.2 allows WordPress core to start getting ready. As an interim measure, while working through the PHP 8.1 and 8.2 issues, builds against these PHP versions are allowed to fail, so that they don't block PR merges in the Gutenberg project. Notes: * The `composer install` command for PHP 8.1 was still using the `--ignore-platform-reqs` option, while that has not been needed anymore for quite a while, so the condition is now reused for PHP 8.2. * The `--ignore-platform...` option used for the install is now made more specific: * Composer 2.0 added a `--ignore-platform-req=...` option to selectively ignore platform requirements. * Composer 2.2 then added the ability to only ignore the upper bound of platform requirements by adding the `+` sign. * Xdebug-related tests will not be run on PHP 8.2 at this time as the Docker image for PHP 8.2 does not contain Xdebug yet. Once a stable release of Xdebug 3.2.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.2. References: * [WordPress/wpdev-docker-images#87 wpdev-docker-images PR WordPress#87: Add PHP 8.2 containers] * [https://github.com/composer/composer/releases/tag/2.0.0 Composer 2.0 changelog] * [https://github.com/composer/composer/releases/tag/2.2.0 Composer 2.2 changelog] * [https://xdebug.org/announcements/2022-07-20 Xdebug 3.2.0alpha1 release notes] * [https://xdebug.org/announcements/2022-07-25 Xdebug 3.2.0alpha2 release notes] Follow-up to [49077], [49162], [50299], [51588], [51604]. Props jrf, desrosj. See #56009. git-svn-id: https://develop.svn.wordpress.org/trunk@53922 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2 is only in the alpha phase, but the 8.2-rc container will continue to update as new pre-release versions are published.
Note: this does not include the Memcached, xDebug, or Imagick extensions. In my local testing, I found the container would not build correctly.