Add rollback auto update #3958
Add rollback auto update #3958
Conversation
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
allows for cleanup of filter hooks from fatal plugin updates
deactivate, use include(), then reactivate. More closely follows plugin_sandbox_scrape()
reactivates plugins with error exceptions
| $ref_temp_backups->setValue( $rollback_updater, $temp_backup ); | ||
|
|
||
| // Call Rollback's restore_temp_backup(). | ||
| $rollback_updater->restore_temp_backup(); |
There was a problem hiding this comment.
I'm probably missing something here (or this is handled in the flow), but I noticed that both this and delete_temp_backup() return WP_Error.
How are these errors usually handled?
Or if it fails, is the assumption that's the best it can do?
There was a problem hiding this comment.
Assuming the errors are handled or expected in some way, I'd love to see a comment explaining the flow.
There was a problem hiding this comment.
Or if it fails, is the assumption that's the best it can do?
That's essentially it yeah.
During an upgrade, restoration and deletion of temp backups occurs during the 'shutdown' action, triggered in a registered shutdown function, when the upgrade process fails.
While these methods might fail, by this point, the previously installed version has already been backed up, the new version downloaded and unpacked to the plugins directory. We should therefore have the permissions and diskspace to do a restore and delete. PHP's shutdown is immune to timeouts, so that's another potential cause of failure avoided.
Nevertheless, we worded the email carefully in saying "may have been restored from a temporary backup" to account for cases that are very hard to predict given our established permissions, diskspace, and timeout immunity.
There was a problem hiding this comment.
Thank you! That makes sense. I would love to see this described in a comment, since it may be clear to some folks, but wasn't immediately so for me, and might make it easier for folks to work on in the future.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
|
Closing in favor of #5287 |
This PR adds the rollback auto update functionality to core. This is already part of the Rollback Update Failure feature plugin.
This requires PR2225. ✅
Trac ticket: https://core.trac.wordpress.org/ticket/58281
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.