Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error modal doesn't show WordPress debug logs #1448

Closed
adamziel opened this issue May 21, 2024 · 7 comments
Closed

Error modal doesn't show WordPress debug logs #1448

adamziel opened this issue May 21, 2024 · 7 comments
Assignees
Labels
[Package][@wp-playground] Website [Type] Enhancement New feature or request [Type] Reliability Playground uptime, reliability, not crashing
Milestone

Comments

@adamziel
Copy link
Collaborator

The error modal showing on a failed Blueprint execution only shows the JavaScript errors but no PHP errors. However, the most useful debugging information are often in the PHP code.

cc @bgrgicak

@adamziel adamziel added [Type] Enhancement New feature or request [Type] Reliability Playground uptime, reliability, not crashing [Package][@wp-playground] Website labels May 21, 2024
@adamziel adamziel added this to the Zero Crashes milestone May 21, 2024
@bgrgicak
Copy link
Collaborator

This could be just a frontend issue. We should check if the PHP logs are printed in the console. If yes, then React didn't pick up the latest data. If no then the PHP logs weren't even sent to the logger from PHP-WASM.

@adamziel
Copy link
Collaborator Author

They are printed in the console

@bgrgicak
Copy link
Collaborator

@adamziel how are you testing this?

When I add a unknown function to a blueprint, it fails, but there are no PHP logs in the browser console.

@bgrgicak
Copy link
Collaborator

At the time request.error is dispatched there is no error log file in my blueprint example.

This means that no PHP logs were recorded.

@adamziel
Copy link
Collaborator Author

adamziel commented Jul 1, 2024

@bgrgicak is this one fixed now?

@adamziel adamziel moved this to Needs Author's Reply in Playground Board Jul 1, 2024
@bgrgicak
Copy link
Collaborator

bgrgicak commented Jul 1, 2024

Yes, it was implemented in #1500

@bgrgicak bgrgicak closed this as completed Jul 1, 2024
@github-project-automation github-project-automation bot moved this from Needs Author's Reply to Done in Playground Board Jul 1, 2024
@bgrgicak
Copy link
Collaborator

bgrgicak commented Jul 1, 2024

I forgot to link the PR to the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package][@wp-playground] Website [Type] Enhancement New feature or request [Type] Reliability Playground uptime, reliability, not crashing
Projects
Archived in project
Development

No branches or pull requests

2 participants