Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Twitter icon with X #470

Closed
jasmussen opened this issue Oct 6, 2023 · 3 comments · Fixed by #461
Closed

Replace Twitter icon with X #470

jasmussen opened this issue Oct 6, 2023 · 3 comments · Fixed by #461
Labels
[Type] Bug Something isn't working

Comments

@jasmussen
Copy link
Collaborator

We currently show this:

Screenshot 2023-10-06 at 09 42 47

Let's update this to the new logo chosen by the company.

I know that a PR has been merged to the Gutenberg plugin to add the icon, let's do that as soon as it's possible as this will also update the link text.

Until then, and if that takes more than a couple of days to do, let's apply a temporary hack. You can use this codepen, but the pertinent bit is this:

.wp-social-link-twitter {
	background: url(https://cldup.com/GnkaLzBcia.svg) no-repeat;
	background-size: 100%;
	
	svg {
		visibility: hidden;
	}
}

That cloudup link is just to show it working in the codepen, but you can snatch the SVG code here. X.svg:

<svg width="24" height="24" viewBox="0 0 24 24" version="1.1" xmlns="http://www.w3.org/2000/svg" aria-hidden="true" focusable="false"><path d="M13.982 10.622 20.54 3h-1.554l-5.693 6.618L8.745 3H3.5l6.876 10.007L3.5 21h1.554l6.012-6.989L15.868 21h5.245l-7.131-10.378Zm-2.128 2.474-.697-.997-5.543-7.93H8l4.474 6.4.697.996 5.815 8.318h-2.387l-4.745-6.787Z"></path></svg>
@jasmussen jasmussen added the [Type] Bug Something isn't working label Oct 6, 2023
@adamwoodnz adamwoodnz transferred this issue from WordPress/wporg-main-2022 Oct 8, 2023
@adamwoodnz
Copy link
Contributor

This is part of the global footer, hence the transfer to the mu-plugins repo.

@StevenDufresne
Copy link
Contributor

@ndiego has a pr for this: #461

@adamwoodnz adamwoodnz linked a pull request Oct 8, 2023 that will close this issue
@ndiego
Copy link
Member

ndiego commented Oct 9, 2023

Yeah 🤞 Gutenberg 16.8 doesn't break things like 16.7, and we can merge #461 later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants