Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow backup codes when another 2FA method exists #21

Closed
pkevan opened this issue Nov 29, 2022 · 11 comments
Closed

Only allow backup codes when another 2FA method exists #21

pkevan opened this issue Nov 29, 2022 · 11 comments
Milestone

Comments

@pkevan
Copy link
Contributor

pkevan commented Nov 29, 2022

Currently you can setup backup codes without an additional method (TOTP, auth key).

If we want to block this workflow, and tie backup codes to only be used as an additional method, then we'll need to rework the logic and possibly restrict backup codes being a primary method.

@pkevan
Copy link
Contributor Author

pkevan commented Nov 29, 2022

Related: #15

@pkevan
Copy link
Contributor Author

pkevan commented Nov 29, 2022

See: pkevan/two-factor@0f6ee66

@iandunn
Copy link
Member

iandunn commented Nov 29, 2022

Related #23

See: pkevan/two-factor@0f6ee66

Was that meant to be posted to #22?

If we're writing a custom UI from scratch, I wonder if it'd be better to use React and Gutenberg components/utilities, instead of jQuery/etc?

@pkevan
Copy link
Contributor Author

pkevan commented Nov 30, 2022

Was that meant to be posted to #22?

Yes! Good catch :)

@pkevan
Copy link
Contributor Author

pkevan commented Nov 30, 2022

If we're writing a custom UI from scratch, I wonder if it'd be better to use React and Gutenberg components/utilities, instead of jQuery/etc?

Probably, i'm just prototyping the functionality and following pre-existing patterns in the plugin.

@pkevan
Copy link
Contributor Author

pkevan commented Nov 30, 2022

We can probably achieve this using the two_factor_providers filter.

@pkevan
Copy link
Contributor Author

pkevan commented Nov 30, 2022

#24 as a potential method for doing this.

@TobiasBg
Copy link

TobiasBg commented Mar 2, 2023

I only found this repo after opening a ticket in Meta Trac, but for reference: https://meta.trac.wordpress.org/ticket/6825

@iandunn
Copy link
Member

iandunn commented Mar 2, 2023

Hey 👋🏻 , sorry you experienced that. WordPress/two-factor#507 is the main cause for it, but #75 and #47 will help mitigate it in the mean time.

@TobiasBg
Copy link

TobiasBg commented Mar 2, 2023

Hi @iandunn, thanks for the context! Yes, that sounds exactly like what happened. The fix sounds reasonable to me as well. (I'm all set again already, thanks to a forums moderator.)

@renintw
Copy link
Contributor

renintw commented Apr 28, 2023

I guess we can close this issue for now since #75 has already been merged and #47 can stand on its own.
@iandunn @pkevan If you feel it's necessary, please feel free to reopen it.

@renintw renintw closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants