Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate CSS kits from React kits #2578

Merged

Conversation

NicholasBoll
Copy link
Member

Summary

Fixes: #2577

Add CSS extraction to the build process

Release Category

Infrastructure


Checklist

  • Label ready for review has been added to PR

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation

Testing Manually

Run yarn build locally and observe the CSS files generated in the css, css-preview, and css-labs modules.

@NicholasBoll NicholasBoll added the ready for review Code is ready for review label Feb 13, 2024
Copy link

cypress bot commented Feb 13, 2024

Passing run #6883 ↗︎

0 908 3 0 Flakiness 0

Details:

Merge 45269e4 into 2ba2e73...
Project: canvas-kit Commit: aba475b452 ℹ️
Status: Passed Duration: 05:08 💡
Started: Feb 13, 2024 5:15 PM Ended: Feb 13, 2024 5:20 PM

Review all test suite changes for PR #2578 ↗︎

@@ -0,0 +1,23 @@
// TODO: This file is needed until v11 is released. We only run lerna bump on support and master,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context.

@alanbsmith alanbsmith added approved Code has been reviewed and approved (ship it) automerge and removed ready for review Code is ready for review labels Feb 13, 2024
@alanbsmith alanbsmith merged commit 0cbfdcb into Workday:prerelease/major Feb 13, 2024
27 of 28 checks passed
@NicholasBoll NicholasBoll deleted the feat/extract-static-css branch February 13, 2024 20:56
@alanbsmith alanbsmith mentioned this pull request Feb 14, 2024
10 tasks
@alanbsmith alanbsmith mentioned this pull request May 14, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11.x approved Code has been reviewed and approved (ship it) automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants