Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update checkbox to use system color tokens #2683

Merged
merged 15 commits into from
Apr 12, 2024
Merged

chore: Update checkbox to use system color tokens #2683

merged 15 commits into from
Apr 12, 2024

Conversation

RayRedGoose
Copy link
Contributor

Summary

Resolves: #2590

New system tokens, color and opacity, have been applied in Checkbox component.

Release Category

Components

Thank You Gif (optional)

Cosmo

@RayRedGoose RayRedGoose self-assigned this Apr 8, 2024
@RayRedGoose RayRedGoose added ready for review Code is ready for review 11.x labels Apr 8, 2024
@RayRedGoose RayRedGoose linked an issue Apr 8, 2024 that may be closed by this pull request
Checkbox Style Refactors - Color Tokens #2590
Closed
@cypress Cypress
Copy link

cypress bot commented Apr 8, 2024 •
edited
Loading

Passing run #7181 ↗︎

0 970 3 0 Flakiness 0

Details:

Merge 6316f81 into fce337a...
Project: canvas-kit Commit: 7c224b83a8 ℹ️
Status: Passed Duration: 04:56 💡
Started: Apr 12, 2024 4:01 PM Ended: Apr 12, 2024 4:06 PM

Review all test suite changes for PR #2683 ↗︎

josh-bagwell
josh-bagwell approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@josh-bagwell josh-bagwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@RayRedGoose RayRedGoose added automerge and removed ready for review Code is ready for review labels Apr 12, 2024
@alanbsmith alanbsmith enabled auto-merge (squash) April 12, 2024 20:49
@alanbsmith alanbsmith enabled auto-merge (squash) April 12, 2024 20:59
@alanbsmith alanbsmith merged commit d76c769 into Workday:prerelease/major Apr 12, 2024
17 checks passed
@RayRedGoose RayRedGoose deleted the ISSUE2590-checkbox-colors branch April 12, 2024 21:07
@alanbsmith alanbsmith mentioned this pull request Apr 24, 2024
Merged
10 tasks
@alanbsmith alanbsmith mentioned this pull request May 14, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasBoll NicholasBoll NicholasBoll approved these changes

@josh-bagwell josh-bagwell josh-bagwell approved these changes

@alanbsmith alanbsmith Awaiting requested review from alanbsmith

Assignees

@RayRedGoose RayRedGoose

Labels
11.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox Style Refactors - Color Tokens
4 participants
@RayRedGoose @NicholasBoll @josh-bagwell @alanbsmith