Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flex styles to mergeStyles #2731

Conversation

NicholasBoll
Copy link
Member

@NicholasBoll NicholasBoll commented May 8, 2024

Summary

Flex style props are not part of mergeStyles. This will cause breaking changes if we remove style props from a component when an application uses flex style props. For example,

<ListBox flexDirection="row">...</ListBox>

If we used a flexDirection style prop in v10, but move it to a Stencil in v11, the flexDirection="row" will no longer work. This is because mergeStyles is covering all style props except for flex style props like flexDirection. The flexDirection prop will be prop drilled all the way down to the Flex layout component which will now be applied under the flexDirection: 'column' of the Stencil, changing the behavior of the style prop. It is not our intention to break style props in v11, so the mergeStyles should handle all style props so that passing style props this way always overrides.

Release Category

Components


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)

@NicholasBoll NicholasBoll added the ready for review Code is ready for review label May 8, 2024
Copy link

cypress bot commented May 8, 2024

Passing run #7283 ↗︎

0 970 3 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 63791b2 into 75c2952...
Project: canvas-kit Commit: 21724548b2 ℹ️
Status: Passed Duration: 16:15 💡
Started: May 8, 2024 9:37 PM Ended: May 8, 2024 9:53 PM

Review all test suite changes for PR #2731 ↗︎

mannycarrera4
mannycarrera4 previously approved these changes May 8, 2024
@mannycarrera4 mannycarrera4 dismissed their stale review May 8, 2024 17:32

failing test

@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels May 8, 2024
@alanbsmith alanbsmith merged commit a458eab into Workday:prerelease/major May 8, 2024
19 checks passed
@NicholasBoll NicholasBoll deleted the feat/add-flex-to-merge-styles branch May 8, 2024 23:00
@alanbsmith alanbsmith mentioned this pull request May 14, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants