Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require approval for new and removed images #42

Open
ScottBishop opened this issue Jun 25, 2019 · 0 comments
Open

Require approval for new and removed images #42

ScottBishop opened this issue Jun 25, 2019 · 0 comments

Comments

@ScottBishop
Copy link
Contributor

The current behavior is:

  • New images are auto-approved and show up as 'new tests'
  • Missing images are just ignored, since no diff is generated for them. But they're still in the 'base image' set

We should instead treat adds/removes as diffs. If needed for data consistency we could even create a white image that's the same size to act as the 'other' in the diff. This would allow us to explicitly approve both removals and additions, and make it more obvious when the test suites change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant