Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release? #2702

Closed
LoZeno opened this issue Jan 17, 2020 · 17 comments
Closed

New Release? #2702

LoZeno opened this issue Jan 17, 2020 · 17 comments
Assignees

Comments

@LoZeno
Copy link

LoZeno commented Jan 17, 2020

Are you submitting a bug report?

No

The last release dates back to 22 December 2018, and since then there's been quite a few improvements to the code; can we finally have a new Release, so that package managers like Scoop and Chocolatey can pick it up?

@jjw24
Copy link
Contributor

jjw24 commented Jan 18, 2020

Hey how's it going. Most of the open PRs have been added to my branch. Feel free to use this one in the mean time:
https://github.com/jjw24/Wox/releases

@BlueDrink9
Copy link

Are there any active contributors? A new release really would be swell

@LoZeno
Copy link
Author

LoZeno commented Jan 18, 2020

Hey how's it going. Most of the open PRs have been added to my branch. Feel free to use this one in the mean time:
https://github.com/jjw24/Wox/releases

Thanks, that is something useful. But the reason for a new release is to allow package managers to pick up updates and allow those who installed wox through said package managers to get the latest version, since the code has been updated several times (plus the PRs you merged in your fork).

@jjw24 Have you considered putting your own fork up into chocolatey or scoop?

@jjw24
Copy link
Contributor

jjw24 commented Jan 18, 2020

Have you considered putting your own fork up into chocolatey or scoop?

At the moment my fork is working on Wox's auto updates. Choco maybe something later but not considered at this stage. I understand your request because I use the package manager extensively.

@vivadavid
Copy link

vivadavid commented Feb 5, 2020

Hi, @jjw24 !

I'd like to know if your fork is like a beta channel (where features and fixes are tested) or if, instead, it's the programme we need to download and use from now on because the original Wox is dead.

I've just got version 1.3.524+JJW24.v1.39.19, but I'm a bit confused about the terminology although I understand it's based on 1.3.524. My confusion is increased by the fact that, on the portable version, there are two subfolders, one of which corresponds to version 1.2.0. On top of that, file Wox.exe appears three times.

There's one more thing I don't understand. I thought "Query search precision" was a new feature, but it's only available when I click on the Wox.exe found on the <app-1.2.0> subfolder.

I just love Wox and I'd like to know how to proceed in the future.

Thanks!

@jjw24
Copy link
Contributor

jjw24 commented Feb 5, 2020

Hi, @jjw24 !

I'd like to know if your fork is like a beta channel (where features and fixes are tested) or if, instead, it's the programme we need to download and use from now on because the original Wox is dead.

Hi @vivadavid, my fork is not a beta channel for Wox. It started with me adding some features and fixes and submitting them back to upstream for everyone else to use. However seeing this upstream repo's development has ceased for over a year, and a couple contributors and myself continued to update Wox, I would say now my fork is continuing the development of Wox until upstream becomes active again.

I've just got version 1.3.524+JJW24.v1.39.19, but I'm a bit confused about the terminology although I understand it's based on 1.3.524. My confusion is increased by the fact that, on the portable version, there are two subfolders, one of which corresponds to version 1.2.0. On top of that, file Wox.exe appears three times.

Use the exe on the top level, Wox\Wox.exe, don't worry about the one in 'app 1.2.0' folder (although both should work the same). Not sure why there are duplicates, seems to be like this since the original 524 version.

There's one more thing I don't understand. I thought "Query search precision" was a new feature, but it's only available when I click on the Wox.exe found on the <app-1.2.0> subfolder.

For me it appear regardless which exe I run. Did you extract the portable version to its own location (not to the original 524 location if you have it installed)?

I just love Wox and I'd like to know how to proceed in the future.

Thanks!

You can use my fork's as it will continue to get refinements.

@BlueDrink9
Copy link

Do you know why upstream isn't merging your changes? I see the maintainer is at least peripherally active

@jjw24
Copy link
Contributor

jjw24 commented Feb 5, 2020

Do you know why upstream isn't merging your changes? I see the maintainer is at least peripherally active

Not sure, have not gotten in touch with the maintainer, but usually it's a combination of things including time commitment, code base complications and PR reviews also take a lot of time especially if they are complex changes.

@vivadavid
Copy link

Hi, @jjw24 !

Thank you for your reply! When I unzipped the portable version of your fork, I had previously formatted my PC, so there was no previous installation.

The first time I ran the Wox.exe located on the top level folder, it actually ran version 1.2, but I've just tried again and it's running 1.3.524, so I'm not sure what's happening here. Maybe the first time I ran the programme, I did run the Wox.exe in the <app-1.2.0> folder. In any case, I should just use the installer and forget about the portable version.

What I can confirm is that version 1.3.524 doesn't show the "Query search precision" feature, but if I close the programme and I specifically run the Wox.exe located in the <app-1.2.0> folder, the feature is there.

From now on, I'll use your fork and I'll stick to the installer.

Thank you for work improving Wox!

@LoZeno
Copy link
Author

LoZeno commented Mar 3, 2020

Pinging @bao-qian to see this since he seems to be active again

@bao-qian
Copy link
Member

Hi guys,

https://github.com/Wox-launcher/Wox/releases

thanks for support and sorry for long, and sorry for making you wait so long.
this project is back to active development, with more than 300 commit and more than 5 release in a month. all old pr has been merged as well.

image

@LoZeno
@BlueDrink9
@vivadavid

@LoZeno
Copy link
Author

LoZeno commented May 14, 2020

@bao-qian Just an FYI: some package managers (like scoop) only pick up new releases from GitHub if they are marked as "Release", not "pre-release".

As such, none of the pre-releases you published so far have appeared for scoop users

@bao-qian
Copy link
Member

@LoZeno
thanks, will mark it as release after collect some user feedback.

@BlueDrink9
Copy link

Thank you for your work!

@LoZeno
Copy link
Author

LoZeno commented May 18, 2020

@bao-qian also noticed that even the users of chocolatey won't see any new update to Wox since they are all marked as pre-release. Most package managers only make full releases available as pre-releases are considered beta and not suitable for most users.

@bao-qian
Copy link
Member

bao-qian commented May 18, 2020

@LoZeno
thanks for info, I'm doing some final testing , will release stable version tomorrow or the after tomorrow.

@jamesdoran
Copy link

@LoZeno
thanks for info, I'm doing some final testing , will release stable version tomorrow or the after tomorrow.

@bao-qian, looks like this was released as 'pre-release' in May last year. When do you plan to do a stable release please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants