Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean source dependency for readability #5

Closed
shinyaohtani opened this issue Feb 16, 2021 · 6 comments
Closed

Clean source dependency for readability #5

shinyaohtani opened this issue Feb 16, 2021 · 6 comments

Comments

@shinyaohtani
Copy link

shinyaohtani commented Feb 16, 2021

I found some improvement for source readability during #4 .

#include <something/something.hpp>

is better than:

#include "../../something/something.hpp"

because ../../ is too strong method we can indicate any files without path setting.

@shinyaohtani shinyaohtani changed the title Clear Inter source dependency Clean source dependency for readability Feb 16, 2021
@X-Ryl669
Copy link
Owner

Yep. I agree, but it also means that you must add -I/path/to/include/folder to compiler flags. For a library that's being included by others, I think it's a pain to do so. Not sure what is the best to do here.

@shinyaohtani
Copy link
Author

You have already added ${CMAKE_CURRENT_SOURCE_DIR}/include, so only we have to do is change the #include statement. we don't need to add -I/path/to/include/folder any more. If you don't like it, just close the PR without merging to master. It's no problem.

@X-Ryl669
Copy link
Owner

No, I meant for those not using cmake, like ESP32. I'll test it tonight and let you know when I'm done.

@shinyaohtani
Copy link
Author

Ah, I see!

@X-Ryl669
Copy link
Owner

I think I've solved the issue, please test the latest master branch and report if it's ok for you.

@shinyaohtani
Copy link
Author

Thank you very much for your prompt response. I think what I pointed out has been properly corrected. So I close this issue. You don't need to merge #6 at all because it is problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants