-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Chinese info #251
add Chinese info #251
Conversation
I get some information about Chinese developers and organizations by processing the given text. I also get some Chinese full repo name from text. Then I get repo_id and actor_id by using GitHub API. And for developers and organizations, I get all repos under them. So I add more repos. |
There are several tricks about this component.
|
OK. I will use org_id to filter repos. However, according to my current stats, the number of actors is very small. Can we get more actors info by other ways? |
I am not sure what do you mean. Do you mean you want more info than actor info in log data? Like? |
Yeah. I only get 60 actors. But we show top 20 active developers. The data looks like small. |
What do you mean 60 actors? For one repo or what? The global active developer accounts are more than 13 million. |
I get actor’s login from text. In the text, the number of Chinese actors is small. |
Oh, I see, actually we can not find out all developer accounts from China, the text accounts mean that all repos under the accounts should be considered as Chinese repos. But we do not make report for Chinese developers because we can not figure out if the contributors' accounts are Chinese or not. |
Shall we show top Chinese active developers in report? |
I don't think it is necessary and we did not do that in 2019 report too. |
OK. |
I assume you may need a |
I can't understand this. I use GitHub API to get id.If I use |
I mean how can you pass the repo id list into SQL renderer? You need to construct the render param string even you got all the repo id and org id list in json config. |
Need to figure out if this works in current render lib, the template engine may not be so powerful. BTW, we use pope as our template engine and according to the documentation, the |
Sorry. I am not sure it works. I will fix it. |
/sql-run |
I found SQL component
The renderred text is: {"err":"data.forEach is not a function"} Please check whether the result is as expected. I found SQL component
The renderred text is:
Please check whether the result is as expected. |
/approve |
False approve. /sql-run |
I found SQL component
The renderred text is: {"err":"data.forEach is not a function"} Please check whether the result is as expected. I found SQL component
The renderred text is:
Please check whether the result is as expected. |
#206