Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_cmt_version must be tested more throughly. #834

Open
WenzDaniel opened this issue Dec 21, 2021 · 3 comments
Open

apply_cmt_version must be tested more throughly. #834

WenzDaniel opened this issue Dec 21, 2021 · 3 comments
Assignees

Comments

@WenzDaniel
Copy link
Collaborator

Currently we are testing apply_cmt_version only very superficially when initializing the online context in straxen. However, I think this function is so fundamental in ensuring that we are applying the correct corrections that I think it must be tested more carefully either in straxen or cutax. We should at least check if all CMT options are updated correctly. A mistake here would not be directly obvious in data.

@WenzDaniel
Copy link
Collaborator Author

In the same PR we should also add tests for correction_name_from_urlstring and replace_url_version.

@WenzDaniel
Copy link
Collaborator Author

and extend the test for is_cmt_option to accommodate the URL config change.

@ershockley
Copy link
Contributor

In #860 I add a few of the tests you mention:

  • I remove correction_name_from_urlstring
  • I add a test for replace_url_version
  • I add a case for is_cmt_option

The big one is definitely apply_cmt_version though, I agree. I think we need to put this into cutax though. That is where we actually define the contexts with specific versions, so it is easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants