-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(character): Add support for fetching PvP team of a character #25
Labels
feature-request
New feature or request
Comments
ReidWeb
added a commit
that referenced
this issue
Jan 2, 2022
… associated to a character Implements #25
ReidWeb
added a commit
that referenced
this issue
Jan 17, 2022
* fix(ci): disable jest report step for dependavot * fix(ci): enable automerge for dependabot prs * chore(deps): bump tmpl from 1.0.4 to 1.0.5 Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * fix(ci): remove branch conditions from build * chore(deps): bump nth-check from 2.0.0 to 2.0.1 Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/fb55/nth-check/releases) - [Commits](fb55/nth-check@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: nth-check dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * test(character): add test for character with shield * fix(character): rename server attribute to be homeWorld * feat(character): add support for parsing Reaper and Sage levels and as active class fixes #19 * feat(character): remove parsing of waist gear Remove support for parsing waist gear due to deprecation with the introduction of 6.0, remove tests. closes #20 * fix(character): fix parsing of free company Resolve issue where free company was being incorrectly parsed. Fixes #21 * chore(gh): move to v2 of issue template for bug form * chore(gh): Add emoji to title of bug report form * chore(gh): complete move to gh-issue-templates v2 * chore(gh): fix link to docs in issue template [skip ci] * ci(actions): add option to suppress build to release workflow * feat(creature): add support for parsing of mount and minion tooltips re #22, re #23 * feat(pvpteam): add support for fetching the name and ID of a pvp team associated to a character Implements #25 * feat(freecompany): update free company parsing to return both id and name * chore(freecompany): fix file issues * feat(creature): add asMapping method * fix(tests): fix issue in character tests where strings were being treated as arrays * chore(formatting): fix formatting of file * refactor(class): Refactor manner in which classes are handled Add support for localizations Restructure significant chunks of code Add support for fetching non-english site versions * refactor(character): update character class map to use new style class * chore(character): add html sample for lodestone maintenance * refactor(all): restructure package structure (phase 1) Migrate towards package/diretory structure structured by logical entity * refactor(all): simplify language mapping types & rename server to world * refactor(all): restructure directory structure further * fix(all): fix bugs added in prior commit * refactor(client): restructure clients to decompose core client * ci(mergify): resolve issues with mergify strict mode deprecation * ci(mergify): Fix tabbing of yml * ci(mergify): Remove deprecated commit_message property * ci(mergify): Fix name of ci job being checked * ci(mergify): Remove status checks github handles these * ci(mergify): Re-add status check * chore(deps): bump follow-redirects from 1.14.3 to 1.14.7 (#29) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Reid <peter@reidweb.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> * ci(tests): decouple unit and integration tests Unit and integration tests no run on separate commands #18 * style(itest): fix lint errors following previous change * fix(ci): fix unit test script command Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Some characters such as 8283 have a PvP team field on their profile. We should parse this back even if we don't use it in the census.
Use Case
As a consumer of the lodestone module I may wish to fetch the pvp team associated to that character.
Proposed Solution
Fetch this in the same manner in which we fetch a grand company or free company.
Add tests to verify that all fields are correctly parsed in the instance that this player belongs to a pvp team
Other information
No response
Acknowledge
The text was updated successfully, but these errors were encountered: