Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize comic titles #94

Closed
roydbt opened this issue Mar 15, 2021 · 4 comments
Closed

Sanitize comic titles #94

roydbt opened this issue Mar 15, 2021 · 4 comments

Comments

@roydbt
Copy link

roydbt commented Mar 15, 2021

The title of #472:

The title should have color, but instead shows the HTML formatting.
@codetheweb
Copy link
Member

Whoops, thanks for pointing that out.

I can't think of an easy way to automatically parse HTML tags in SwiftUI, so I think the better method (and what xkcd: OS does) is to sanitize the title before adding it to the database.

@codetheweb codetheweb transferred this issue from XKCDY/app Mar 15, 2021
@codetheweb codetheweb changed the title The title of #472 Sanitize comic titles Mar 15, 2021
@codetheweb
Copy link
Member

After looking into this more, it appears a sanitized version is already provided by xkcd and is currently being saved in a different field, so it is actually an app issue. 🙄

@codetheweb codetheweb transferred this issue from XKCDY/api Mar 16, 2021
@codetheweb
Copy link
Member

3d7b387, I'll update this when it's approved and ready in the store.

@codetheweb
Copy link
Member

Version v1.2.5 is now available in the store. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codetheweb @roydbt