Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't process incoming L_Data.con confirmation frames #324

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Don't process incoming L_Data.con confirmation frames #324

merged 2 commits into from
Aug 12, 2020

Conversation

farmio
Copy link
Member

@farmio farmio commented Aug 10, 2020

Incoming L_Data.con frames get an ACK, but are not processed (and not checked in any way).

Quickfix for #323

@coveralls
Copy link

coveralls commented Aug 10, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 91.789% when pulling 38570d5 on farmio:tunneling-l-data-con into 58aca20 on XKNX:next.

@marvin-w
Copy link
Member

Nice catch! Looks fine for me.

@marvin-w marvin-w merged commit 04905e0 into XKNX:next Aug 12, 2020
This was referenced Sep 12, 2020
Closed
Closed
@farmio farmio mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvin-w marvin-w marvin-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farmio @coveralls @marvin-w